B12: normalise traceback paths; make tests pass on Windows

Author: Kanak234

.github/workflows/windows-tests.yml

@@ -32,4 +32,4 @@ jobs:
       - name: pyflakes
         run: python -m pyflakes medha
       - name: pytest (offline)
-        run: python -m pytest -q
+        run: python -m pytest -q -rs

docs/MEDHA-v2-PLAN.md

@@ -26,6 +26,7 @@ Release rule: fix and push all month, publish to the Store **once** at the end (
 | B9 | High | Closing an edited tab discarded unsaved work without confirmation. | `app.py` close_tab/closeEvent | Save/Discard/Cancel guard, including cancelled Save As. |
 | B10 | Medium | `ProjectExplorerWidget.__init__` doesn't call `load_workspace()`, so workspace projects aren't loaded and fallback logic creates a project with the workspace directory name. | `medha/project_manager.py` line 192 | Add `self.workspace_manager.load_workspace(workspace_path)` in `__init__`. |
 | B11 | **High** | Windows terminal never used ConPTY: code imported `pywinpty` (real module is `winpty`), wrong `spawn` args, blocking `read()` on the GUI thread, `send_control` doesn't exist; pywinpty not in build deps. Fallback never set `_shell_started` (commands stuck) and its Ctrl+C killed the shell. | `medha/terminal.py`, `requirements.txt`, spec | Fixed: `winpty` import, reader thread, `sendintr()`, fallback sets started + Ctrl+C terminates only shell children (psutil); `windows-tests.yml` runs the real-ConPTY test on windows-latest. |
+| B12 | Low | Python traceback line was wrong on Windows: frame-path filter compared paths without abspath/normcase on both sides. | `medha/runner.py` parse_python_traceback | Fixed: normalise both sides. Tests made path-portable for the Windows CI job. |
 More bugs come from Track B (section 3) — append them to this table with the same columns.
 
 ## 2. Track A — New UI like VS Code / Antigravity (ChatGPT)

medha/runner.py

@@ -161,8 +161,12 @@ def parse_diagnostics(self, text):
 
     def parse_python_traceback(self, text):
         """Last frame inside the user's own files + the exception line → one diagnostic."""
+        # Keep only frames from the user's own folder. Both sides go through
+        # abspath+normcase, so Windows drive letters, "\\" vs "/" and letter case
+        # can't make a user frame look foreign (was B12: wrong line on Windows).
+        mine = os.path.normcase(os.path.dirname(os.path.abspath(self.active_file)))
         frames = [(f, int(l)) for f, l in PY_FRAME_RE.findall(text)
-                  if not f.startswith("<") and os.path.abspath(f).startswith(os.path.dirname(self.active_file))]
+                  if not f.startswith("<") and os.path.normcase(os.path.abspath(f)).startswith(mine)]
         errs = PY_ERROR_RE.findall(text)
         if not errs:
             return

tests/test_debugger.py

@@ -11,6 +11,7 @@
 - Clean termination
 """
 
+import os
 import json
 import socket
 import time
@@ -318,7 +319,7 @@ def test_set_breakpoint_debugpy_sends_setBreakpoints(self):
             session.send_dap_request.assert_called_once()
             args = session.send_dap_request.call_args[0]
             assert args[0] == "setBreakpoints"
-            assert args[1]["source"]["path"] == "/tmp/test.py"
+            assert args[1]["source"]["path"] == os.path.abspath("/tmp/test.py")
             assert args[1]["breakpoints"][0]["line"] == 42
 
     def test_set_breakpoint_debugpy_fails_on_unverified(self):
@@ -416,7 +417,7 @@ class TestDebugSessionCommon:
     def test_init_sets_attributes(self):
         """DebugSession.__init__ sets target path and kind."""
         session = DebugSession("/tmp/test", kind="gdb")
-        assert session.target == "/tmp/test"
+        assert session.target == os.path.abspath("/tmp/test")
         assert session.kind == "gdb"
         assert session.proc is None
         assert session.sock is None

tests/test_release_metadata.py

@@ -14,15 +14,15 @@ def test_package_versions_agree():
     assert identity.attrib['Version'] == __version__ + '.0'
     appstream = ET.parse(ROOT / 'packaging/io.github.Kanak234.Medha.metainfo.xml')
     assert appstream.find('releases/release').attrib['version'] == __version__
-    assert f'**Prepared version:** {__version__}' in (ROOT / 'store/listing.md').read_text()
-    snap = (ROOT / 'snap/snapcraft.yaml').read_text()
+    assert f'**Prepared version:** {__version__}' in (ROOT / 'store/listing.md').read_text(encoding='utf-8')
+    snap = (ROOT / 'snap/snapcraft.yaml').read_text(encoding='utf-8')
     assert 'adopt-info: medha-app' in snap
     assert 'craftctl set version="$VERSION"' in snap
     # Snap derives its version from the same app constant instead of a second literal.
 
 
 def test_partner_center_copy_is_short_and_does_not_claim_pending_terminal():
-    listing = (ROOT / 'store/listing.md').read_text()
+    listing = (ROOT / 'store/listing.md').read_text(encoding='utf-8')
     copy = listing.split('<!-- WHATS_NEW_START -->')[1].split('<!-- WHATS_NEW_END -->')[0].strip()
     assert 0 < len(copy) < 1500
     assert all(line.startswith('- ') for line in copy.splitlines())

tests/test_terminal_pty.py

@@ -218,6 +218,7 @@ def test_ctrl_c_stops_command_not_shell(self, qapp):
 # ---------------------------------------------------------------------------
 
 class TestCreatePtyBackend:
+    @pytest.mark.skipif(sys.platform == "win32", reason="the pty module needs termios (POSIX only)")
     @patch("medha.terminal.P")
     def test_unix_chooses_unix_pty(self, mock_P, qapp):
         """On Linux/macOS, factory returns _UnixPtyProcess."""

tests/test_toolchains.py

@@ -182,10 +182,12 @@ def test_bundled_before_path(self, mock_probe, mock_bundled_dir, mock_settings):
         # Mock EXE suffix for the platform (imported at module level in toolchains)
         with patch("medha.toolchains.EXE", ".exe"):
             with patch("os.path.isfile") as mock_isfile:
-                mock_isfile.side_effect = lambda p: p == "/app/toolchains/mingw64/bin/gcc.exe"
+                # Path() gives native separators, so build the expectation the same way (Windows uses "\\").
+                expected = str(Path("/app/toolchains") / "mingw64" / "bin" / "gcc.exe")
+                mock_isfile.side_effect = lambda p: str(p) == expected
                 with patch("shutil.which", return_value="/usr/bin/gcc"):
                     tool = find("gcc")
-                    assert tool.path == "/app/toolchains/mingw64/bin/gcc.exe"
+                    assert str(tool.path) == expected
                     assert tool.source == "bundled"
 
     @patch("medha.toolchains.settings.get", return_value={})

tests/test_ui_smoke.py

@@ -94,7 +94,7 @@ def test_menu_order_and_existing_actions_preserved(window):
     from medha.command_palette import collect_actions
     menus = [a.text().replace('&', '') for a in window.menuBar().actions()]
     assert menus == ['File', 'Edit', 'Selection', 'View', 'Go', 'Run', 'Terminal', 'Help']
-    original = json.loads((Path(__file__).parent / 'fixtures/v1_actions.json').read_text())
+    original = json.loads((Path(__file__).parent / 'fixtures/v1_actions.json').read_text(encoding='utf-8'))
     before = Counter(text.replace('&', '') for text in original)
     after = Counter(action.text().replace('&', '') for _, action in collect_actions(window.menuBar()))
     assert not (before - after)