From 1921506003ff963a4ef5fd3f564f57ae45856151 Mon Sep 17 00:00:00 2001 From: William Schmitt Date: Fri, 13 Nov 2026 11:13:27 -0800 Subject: [PATCH] ci: tag releases when a release PR merges The push guard from the release-on-demand change never matched. After the 1.26.0 / 2.27.0 release PRs merged, the push run skipped the release-please job (sdk-python run 43488257883) even though the merge commit modifies .release-please-manifest.json, so contains(toJSON(github.event.commits.*.modified), ...) was false and nothing was tagged until Release Please was dispatched by hand. A paths filter on the push trigger does the same job off the pushed diff, so the job-level guard keeps only the repository check. Co-Authored-By: Claude Opus 5.5 --- .github/workflows/release-please.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index d4d63691..f3fe7d0f 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -3,6 +3,8 @@ on: push: branches: - main + paths: + - .release-please-manifest.json workflow_dispatch: permissions: @@ -13,10 +15,7 @@ jobs: release-please: # Release PRs open only when someone runs this workflow. A push runs it only # when a release PR merges (it bumps the manifest), to tag the release. - if: >- - github.repository == 'browserbase/sdk-python' && - (github.event_name == 'workflow_dispatch' || - contains(toJSON(github.event.commits.*.modified), '.release-please-manifest.json')) + if: github.repository == 'browserbase/sdk-python' runs-on: ubuntu-latest steps: