From 6c56071944c5b41d77ef110040f2f9ef2473671f Mon Sep 17 00:00:00 2001 From: BlueX888 <140241684+BlueX888@users.noreply.github.com> Date: Mon, 9 Nov 2026 18:49:53 +0800 Subject: [PATCH] Fix own_client so close() closes the client created internally --- reportportal_client/aio/client.py | 3 ++- tests/aio/test_batched_client.py | 13 ++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/reportportal_client/aio/client.py b/reportportal_client/aio/client.py index d3ebe7a..ad33528 100644 --- a/reportportal_client/aio/client.py +++ b/reportportal_client/aio/client.py @@ -771,6 +771,7 @@ def __setstate__(self, state: dict[str, Any]) -> None: :param dict state: object state dictionary """ self.__dict__.update(state) + self._session = None class AsyncRPClient(RP): @@ -1365,7 +1366,7 @@ def __init__( self.own_client = False else: self.__client = Client(endpoint, project, **kwargs) - self.own_client = False + self.own_client = True self.__launch_uuid = launch_uuid if launch_uuid: diff --git a/tests/aio/test_batched_client.py b/tests/aio/test_batched_client.py index 48343ff..56e72c5 100644 --- a/tests/aio/test_batched_client.py +++ b/tests/aio/test_batched_client.py @@ -18,16 +18,27 @@ # noinspection PyPackageRequirements import pytest -from reportportal_client.aio import BatchedRPClient +from reportportal_client.aio import BatchedRPClient, ThreadedRPClient from reportportal_client.core.rp_requests import AsyncRPRequestLog from reportportal_client.helpers import timestamp +@pytest.mark.parametrize("client_class", [BatchedRPClient, ThreadedRPClient]) +def test_own_client_reflects_client_ownership(client_class): + owned = client_class("http://endpoint", "project", api_key="api_key") + assert owned.own_client is True + + borrowed = client_class("http://endpoint", "project", api_key="api_key", client=mock.AsyncMock()) + assert borrowed.own_client is False + + def test_batched_rp_client_pickling(): client = BatchedRPClient("http://localhost:8080", "default_personal", api_key="test_key") pickled_client = pickle.dumps(client) unpickled_client = pickle.loads(pickled_client) assert unpickled_client is not None + assert unpickled_client.own_client is True + unpickled_client.close() async def __empty_string():