From 7849a10c939cc1543ab5535a8af0ec0baf503a08 Mon Sep 17 00:00:00 2001 From: Hugo Castro de Deco Date: Wed, 11 Nov 2026 17:20:11 -0300 Subject: [PATCH] Fix netstandard dependency compatibility for pre-net8 consumers --- .github/workflows/build.yml | 3 +++ Directory.Packages.props | 5 ++++- src/Renci.SshNet/Renci.SshNet.csproj | 2 ++ test/Renci.SshNet.Tests/Common/AsyncSocketListener.cs | 4 ++++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2abbe4406..f768ff9e7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -44,6 +44,9 @@ jobs: -p:CoverletOutput=../../coverlet/linux_unit_test_net_10_coverage.xml \ test/Renci.SshNet.Tests/ + - name: Run Unit Tests against the .NET Standard asset + run: dotnet test -f net10.0 -p:SshNetTargetFramework=netstandard2.0 test/Renci.SshNet.Tests/ + - name: Run Integration Tests .NET run: | dotnet test \ diff --git a/Directory.Packages.props b/Directory.Packages.props index 2ed0dc3e9..b34bbd61a 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -10,6 +10,7 @@ + @@ -21,7 +22,9 @@ - + + + \ No newline at end of file diff --git a/src/Renci.SshNet/Renci.SshNet.csproj b/src/Renci.SshNet/Renci.SshNet.csproj index 9b7af1590..1a629cd0a 100644 --- a/src/Renci.SshNet/Renci.SshNet.csproj +++ b/src/Renci.SshNet/Renci.SshNet.csproj @@ -5,6 +5,7 @@ SSH.NET SSH.NET net462;netstandard2.0;net8.0;net9.0;net10.0 + $(SshNetTargetFramework) @@ -54,6 +55,7 @@ + diff --git a/test/Renci.SshNet.Tests/Common/AsyncSocketListener.cs b/test/Renci.SshNet.Tests/Common/AsyncSocketListener.cs index 575d37160..ae0285a83 100644 --- a/test/Renci.SshNet.Tests/Common/AsyncSocketListener.cs +++ b/test/Renci.SshNet.Tests/Common/AsyncSocketListener.cs @@ -5,6 +5,10 @@ using System.Net.Sockets; using System.Threading; +#if NET9_0_OR_GREATER +using Lock = System.Threading.Lock; +#endif + using Renci.SshNet.Common; #pragma warning restore IDE0005