Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues / Observations:
API contract change (breaking): The endpoint path changed from
/auth/ldap/login/${accessToken}to a fixed/auth/ldap/loginwithaccessTokenmoved into query params. Ensure the backend actually supports the query-param variant; otherwise this is a behavioral regression.Potential inconsistency with
postLogin: If the siblingpostLoginstill uses the path-segment pattern, the two login functions now diverge in how they passaccessToken. Verify this divergence is intentional.Undefined
params: Passingparams: undefinedis generally harmless in axios, but some wrappers/interceptors may not handle it consistently. Prefer building the config object conditionally or letting the library ignore it (usually fine).Semantic/security concern: Moving an access token from path to query string does not materially change exposure (both are logged), but query strings are more commonly logged by proxies/servers. Confirm logging policies.
Type safety: No explicit typing on the new
paramsobject; minor, but consider typing for consistency.Optimization suggestion: Use a spread/conditional to avoid passing
undefined:Also add/update a unit test asserting the correct URL + params for both cases (with and without
accessToken).