Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No syntax-level irregularity is introduced by this diff. The changed argument appears intentional: if the backend really treats
order_asc = true(or omitted) as descending, then passingtruematches the comment “latest first”, and the store can reverse it internally for display.Potential issues / suggestions:
Inverted boolean semantics are brittle
order_asc: truemeaning “descending” is highly misleading and easy to regress.{ order: 'asc' | 'desc' }.props.applicationId || ''silently hides invalid stateapplicationIdis required for this API call, failing early is safer than sending''.?? ''if onlynull/undefinedshould fall back.Add a regression test
Minor optimization / readability
pageRecordscallback avoids recreating it inline and makes it easier to test:pageRecordsreactively.Overall: the diff is probably correct if and only if the documented backend behavior is accurate. The main risk is the inverted, magic boolean value.