Repository navigation
fix: application chat user permission error - #7939
Merged
Merged
Conversation
shaohuzhang1
commented
Nov 16, 2026
| <el-switch :disabled="!applicationchatUserPermission('chatUserEdit')" :model-value="currentGroup.is_auth" size="small" @change="handleAutoAuthorizationChange" /> | ||
| </div> | ||
| </div> | ||
| <!-- 保存对话用户授权 --> |
Contributor
Author
There was a problem hiding this comment.
No syntax/logic error is obvious in this diff, but there are a few review points:
-
Permission behavior changed from “hidden” to “visible but disabled”
- Before: unauthorized users did not see the auto-authorization switch.
- After: everyone sees the switch, but unauthorized users cannot interact with it.
- This may be intentional, but it also exposes the current
currentGroup.is_authstate to users withoutchatUserEdit. If that state should not be visible, keepv-ifor combine both:If the disabled state is desired for UX consistency, the current approach is acceptable.<div v-if="applicationchatUserPermission('chatUserEdit')" ...>
-
Frontend permission is not security
:disabledonly prevents UI interaction.handleAutoAuthorizationChangeand the backend API must still enforcechatUserEdit. Do not rely on the disabled switch for authorization.
-
Add a guard in the handler
- Even with
disabled, it is safer to guard the mutation handler:const handleAutoAuthorizationChange = (value: boolean) => { if (!applicationchatUserPermission('chatUserEdit')) return // ... }
- Even with
-
Avoid repeated permission function calls in the template
- If
applicationchatUserPermissionis non-trivial or depends on reactive state, use a computed:const canEditChatUser = computed(() => applicationchatUserPermission('chatUserEdit') )
<el-switch :disabled="!canEditChatUser" ... />
- Ensure the permission check is reactive; otherwise the disabled state may not update when permissions change.
- If
-
Consider boolean normalization
- If
currentGroup.is_authcan beundefined/null, use:This avoids unexpected switch state.:model-value="!!currentGroup?.is_auth"
- If
-
UX/accessibility
- A disabled control without explanation can confuse users. If you keep it visible, consider a tooltip such as “You do not have permission to edit this setting.”
Overall: the diff is valid, but the main concerns are permission visibility, backend enforcement, and handler-side authorization guarding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: application chat user permission error