Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one-line change is syntactically valid Vue template code. No obvious syntax irregularity in the diff. However, there are several review points:
Permission semantics may be wrong
overviewPublicsounds like a “view public overview” permission, not necessarily a permission to reset an access token.overviewPublicResetToken/resetAccessTokenif available.Frontend hiding is not authorization
v-ifonly hides the button. The reset API must still enforce the same permission server-side and return403if unauthorized.Reactivity concern
applicationOverviewPermission()depends on a reactive permission store, the template will re-render correctly.v-ifmay not update correctly. Prefer a computed property:Ensure the permission function returns a synchronous boolean
Promise,v-ifwill treat it as truthy. Permission checks in templates should be synchronous.Check import/definition
applicationOverviewPermissionis imported or defined in this component; otherwise it will fail at runtime.Shared
loadingstateloadingis shared by multiple buttons/actions, resetting the token may make unrelated buttons show loading. Consider a dedicatedresettingAccessTokenstate.UX/security suggestions
finally.aria-labelortitlefor the icon-only button, e.g. “Reset access link”.Overall: the change is safe syntactically, but verify the permission key is the correct one, keep the check reactive, and ensure backend authorization is also enforced.