Repository navigation
Adding a guard so a panic inside the Lattice impl leads to an abort - #186
Merged
Merged
Conversation
…ather than UB. Validated no perf impact and does not interfere with catching panics that come from outside the Lattice implementation
Adam-Vandervorst
approved these changes
Nov 11, 2026
Bench A/B vs base: donejob log · 2026-11-11 12:09:55 UTC base 8172d18 → head 7b404e7, 3 round(s), median of each run averaged; negative is faster
27 case(s) moved more than 5%
Full tables per bench are in the job log and the bench-out artifact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a guard so a panic inside the Lattice impl leads to an abort, rather than UB. Validated no perf impact and does not interfere with catching panics that come from outside the Lattice implementation.
Addresses #185