Skip to content

[ALICE3] Align ACTSO2 Translator to the new output - #18463

Merged
njacazio merged 7 commits into
AliceO2Group:masterfrom
lhusova:TrackingTranslatorFix
Nov 6, 2026
Merged

njacazio merged 7 commits into
AliceO2Group:masterfrom
lhusova:TrackingTranslatorFix

Conversation

@lhusova

@lhusova lhusova commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Adjusments in the Tracking Translator to the updated actso2 output

@github-actions github-actions Bot changed the title ALICE3: Modification of the alice3TrackingTranslator.cxx due to the modified actso2 output [ALICE3] Modification of the alice3TrackingTranslator.cxx due to the modified actso2 output Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 138 warnings, 🔕 0 disabled

njacazio
njacazio previously approved these changes Oct 28, 2026
@njacazio
njacazio marked this pull request as ready for review October 29, 2026 03:55
@njacazio njacazio changed the title [ALICE3] Modification of the alice3TrackingTranslator.cxx due to the modified actso2 output [ALICE3] Align ACTSO2 Translator to the new output Oct 29, 2026
@njacazio
njacazio enabled auto-merge (squash) October 29, 2026 03:56
@njacazio
njacazio disabled auto-merge October 29, 2026 03:58
@alibuild

alibuild commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 42fbf87 at 2026-11-06 10:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 9 errors and 45 warnings.'
Found 9 errors and 45 warnings.
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/9902b53fb553aa4efdc270c355490a66b3060a63/O2Physics-code-check/errors.txt
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:91: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:112: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:210:88: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:210:109: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:322:87: error: std::move of the const variable 'filename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:322:108: error: std::move of the const variable 'treename' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:494:45: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
ALICE3/TableProducer/alice3strangenessFinder.cxx:268:45: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Tasks/alice3Strangeness.cxx:874:20: error: no header providing "RecoDecay" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/9902b53fb553aa4efdc270c355490a66b3060a63/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:262:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:798:7: warning: switch has 2 consecutive identical branches [bugprone-branch-clone]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:58:9: warning: variable 'inputPath' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:103:9: warning: function-like macro 'SETADDRESS' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:104:44: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:105:58: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:109:5: warning: constructor does not initialize these fields: mTree [cppcoreguidelines-pro-type-member-init]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:331:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:332:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:363:20: warning: variable 'file' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:471:59: warning: narrowing conversion from 'double' to 'mapped_type' (aka 'int') [bugprone-narrowing-conversions]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:496:34: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:501:37: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:503:15: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:509:38: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:763:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
ALICE3/TableProducer/alice3strangenessFinder.cxx:498:7: warning: uninitialized record type: 'dcaInfo' [cppcoreguidelines-pro-type-member-init]
ALICE3/Tasks/alice3Strangeness.cxx:60:8: warning: constructor does not initialize these fields: appliedSelectionCheckMask, selectionCheck, selectionCheckPos [cppcoreguidelines-pro-type-member-init]
ALICE3/Tasks/alice3Strangeness.cxx:173:13: warning: member 'posDaugDCAselIDx' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/Tasks/alice3Strangeness.cxx:174:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/Tasks/alice3Strangeness.cxx:218:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
ALICE3/Tasks/alice3Strangeness.cxx:452:91: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:455:91: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:458:78: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:461:69: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 28e0a60 at 2026-11-06 11:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 9 warnings.'
Found 5 errors and 9 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/780119fce2cfac9e55657b25fc8576de153c1a5d/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:101:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:22:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:39:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/alice3strangenessFinder.cxx:268:45: error: no header providing "TH2" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Tasks/alice3Strangeness.cxx:897:20: error: no header providing "RecoDecay" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/780119fce2cfac9e55657b25fc8576de153c1a5d/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:798:7: warning: switch has 2 consecutive identical branches [bugprone-branch-clone]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:60:9: warning: variable 'inputPath' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:133:12: warning: use default member initializer for 'mTree' [modernize-use-default-member-init]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:475:59: warning: narrowing conversion from 'double' to 'mapped_type' (aka 'int') [bugprone-narrowing-conversions]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:500:34: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:505:37: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:507:15: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:513:38: warning: use 'contains' to check for membership [readability-container-contains]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:767:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for af4d949 at 2026-11-06 13:14:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 3 warnings.'
Found 1 errors and 3 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/1f4c3224b54131417ffd7272acdf66cd6d825844/O2Physics-code-check/errors.txt
ALICE3/TableProducer/alice3TrackingTranslator.cxx:38:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/1f4c3224b54131417ffd7272acdf66cd6d825844/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyTracker.cxx:797:7: warning: switch has 2 consecutive identical branches [bugprone-branch-clone]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:59:9: warning: variable 'inputPath' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
ALICE3/TableProducer/alice3TrackingTranslator.cxx:105:109: warning: member initializer for 'mTree' is redundant [modernize-use-default-member-init]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@njacazio
njacazio enabled auto-merge (squash) November 6, 2026 13:46
@njacazio
njacazio merged commit 6d586d0 into AliceO2Group:master Nov 6, 2026
13 of 15 checks passed
DelloStritto pushed a commit to DelloStritto/O2Physics that referenced this pull request Nov 9, 2026
Co-authored-by: Lucia Anna Tarasovicova <lucia.anna.husova@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants