Skip to content

[PWGDQ] Refactor the AnalysisDileptonTrackTrack and add process function for … - #18673

Merged
iarsene merged 4 commits into
AliceO2Group:masterfrom
iarsene:master
Nov 9, 2026
Merged

[PWGDQ] Refactor the AnalysisDileptonTrackTrack and add process function for …#18673
iarsene merged 4 commits into
AliceO2Group:masterfrom
iarsene:master

Conversation

@iarsene

@iarsene iarsene commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

…K+K-pi+pi-

@github-actions github-actions Bot added the pwgdq label Nov 9, 2026
@github-actions github-actions Bot changed the title Refactor the AnalysisDileptonTrackTrack and add process function for … [PWGDQ] Refactor the AnalysisDileptonTrackTrack and add process function for … Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1039 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Nov 9, 2026
Merged
iarsene added a commit to iarsene/O2Physics that referenced this pull request Nov 9, 2026
@iarsene
Merge pull request #36 from alibuild/alibot-cleanup-18673
7296824 
[PWGDQ] Please consider the following formatting changes to AliceO2Group#18673
@alibuild

alibuild commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 7296824 at 2026-11-09 23:50:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Nov 9, 2026
Merged
@iarsene
Merge pull request #37 from alibuild/alibot-cleanup-18673
348c4fd 
Please consider the following formatting changes to AliceO2Group#18673
@alibuild

alibuild commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 7296824 at 2026-11-09 23:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@iarsene
iarsene enabled auto-merge (squash) November 9, 2026 23:06
alibuild
alibuild approved these changes Nov 9, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @iarsene.

@alibuild

alibuild commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7296824 at 2026-11-10 00:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 9 warnings.'
Found 2 errors and 9 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/7fedb1f84d934de075f54007047fc6e124e366e9/O2Physics-code-check/errors.txt
PWGDQ/Tasks/tableReader_withAssoc.h:824:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.h:5142:33: error: comparison of integers of different signs: 'int' and 'uint32_t' (aka 'unsigned int') [clang-diagnostic-sign-compare,-warnings-as-errors]
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/7fedb1f84d934de075f54007047fc6e124e366e9/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.h:1262:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1263:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1679:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:4761:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5496:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5499:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5500:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/tableReader_withAssoc.h:4906:36: warning: initializer for member 'fDileptonCut' is redundant [readability-redundant-member-init]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@iarsene
iarsene merged commit ae47881 into AliceO2Group:master Nov 9, 2026
14 of 15 checks passed
@alibuild

alibuild commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 348c4fd at 2026-11-10 00:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 9 warnings.'
Found 1 errors and 9 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/3ae813d43c0675252b81a45616d73b6a23868a9e/O2Physics-code-check/errors.txt
PWGDQ/Tasks/tableReader_withAssoc.h:824:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
++ [[ 9 -gt 0 ]]
++ cat /sw/BUILD/3ae813d43c0675252b81a45616d73b6a23868a9e/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.h:1262:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1263:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1679:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1683:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:4761:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5496:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5499:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5500:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Tasks/tableReader_withAssoc.h:4906:36: warning: initializer for member 'fDileptonCut' is redundant [readability-redundant-member-init]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

vkucera
vkucera reviewed Nov 12, 2026
View reviewed changes
Comment thread PWGDQ/Tasks/tableReader_withAssoc.h
std::vector<AnalysisCut*> addTrackCuts = o2::aod::dqcuts::GetCutsFromJSON(addTrackCutsStr.Data());
for (auto const& t : addTrackCuts) {
fTrackCuts.push_back(dynamic_cast<AnalysisCompositeCut*>(t));
fTrackCuts.push_back(reinterpret_cast<AnalysisCompositeCut*>(t));

@vkucera vkucera Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iarsene , why did you change this? reinterpret_cast should not be used here.

@vkucera vkucera mentioned this pull request Nov 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild alibuild approved these changes
@XiaozhiBai XiaozhiBai Awaiting requested review from XiaozhiBai XiaozhiBai is a code owner
@mguilbau mguilbau Awaiting requested review from mguilbau mguilbau is a code owner
@axti98 axti98 Awaiting requested review from axti98 axti98 is a code owner
@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner
@glegras glegras Awaiting requested review from glegras glegras is a code owner
@shreyasiacharya shreyasiacharya Awaiting requested review from shreyasiacharya shreyasiacharya is a code owner

Assignees

No one assigned

Labels

pwgdq

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iarsene @alibuild @vkucera