Repository navigation
Conversation
The words of the descendants were only measured once their own layout ran, so on the first layout pass an auto width float or absolutely positioned box got a width of 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A float with an auto width got a width of 0 on the first layout pass, so it wasn't painted and the text next to it was only indented by the float's margin. Calling
PerformLayouta second time fixed it, which is why exported images looked fine, asHtmlRender.RenderToImage*measures and then lays out again, whileHtmlPanelusually lays out once perTextchange and the float stayed invisible.The shrink-to-fit width (CSS 2.1 §10.3.5 and §10.3.7) adds up the widths of the words inside the box, but a box only measures its own words once its layout runs, and the float's children come after it. On the second pass the measurements were cached. Tables already measure all their descendants first, so that helper moved to
CssBoxand the float and absolute position path uses it too.This was already recorded as a gap in the spec manifests, both gap tests pass now and lost their
[Ignore]:AutoWidthFloat_ShrinksToFitItsContentAbsolute_WithAutoWidth_ShrinksToFitItsContent10.3.5 is supported now and the gap is removed from 10.3.7, css-sizing-3/4 and css-position-3.
AutoWidthFloat_IsSizedByTheFirstLayoutadditionally covers the reported case, a float with a large font in anoverflow: hiddenblock, laid out once, and checks that a second pass doesn't change the container's size.How to test this PR?
CI should succeed. The image regression baselines are unchanged and the spec compliance check reports no problems.