Repository navigation
Add guided Requirements Builder canvas (Fixes AB#3822851) - #496
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3822851 to an Azure Boards work item. |
…caping or encoding' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
| try { | ||
| for (const [key, change] of pending) { | ||
| state = await api("/update", { revision: state.draft.revision, change }); | ||
| if (pending.get(key) === change) pending.delete(key); |
There was a problem hiding this comment.
This can lose edits if someone keeps typing while a save is in flight.
If the same field changes during the await, the newer change stays in pending, but this loop doesn't revisit that key. perform() then continues into the action, which can rerender the editor from the older saved answer.
I reproduced this by holding one save response, clicking Ask AI, and typing a newer answer before releasing the response. After autosave settled, the editor showed the older text even though the newer text was saved, and the UI reported "Saved". Continuing to type in that editor then overwrote the newer saved answer, with no error.
Could we make sure the pending edits are fully drained before proceeding, and preserve any input entered while the action itself is awaiting a response? A browser regression test that types into the same field during an in-flight save would help cover this.
There was a problem hiding this comment.
Copilot , can you assess this comment if we should address it
There was a problem hiding this comment.
Yes—this is actionable because a newer local edit can be persisted while the editor is rerendered from an older response. Fixed in 662f925: saves now drain all pending edits, and action responses retain the latest pending input.
| if (!Object.hasOwn(draft.metadata, key) || typeof value !== "string" || value.length > 20000) throw new Error("Invalid metadata."); | ||
| if (key === "uiKind" && !["unknown", "authenticator", "other-ui", "non-ui"].includes(value)) throw new Error("Invalid UI applicability."); | ||
| } | ||
| Object.assign(draft.metadata, change.metadata); |
There was a problem hiding this comment.
Could we also revalidate the existing accessibility answer when uiKind changes? Right now the N/A check only runs when the answer itself is submitted, so the order of filling out the form changes what is allowed.
For example:
- Leave applicability as Not sure yet.
- Mark the accessibility section N/A with a reason.
- Change applicability to New or changed Authenticator UI.
I verified that the earlier N/A answer survives this transition. The exported accessibility table still says N/A, the detailed mandatory baselines (including the 48dp touch-target requirement) disappear, and the section isn't listed as an unresolved gap. Submitting the same N/A answer after selecting Authenticator correctly fails.
When switching to Authenticator UI, we should flag the incompatible N/A answer for the author to resolve and retain the mandatory baselines, without inventing feature-specific answers. A regression test covering this applicability transition would help keep the requirement consistent.
There was a problem hiding this comment.
Prior accessibility N/A answers now become Unknown when applicability changes to Authenticator UI. This exposes the gap while restoring mandatory baselines and leaving feature-specific requirements unresolved. Added a transition regression test in 87937eb.
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Why a shared canvas
Add a team-shared GitHub Copilot repository canvas extension, not a hosted website. The canvas uses Copilot's extension SDK and current-session conversation admission, with local loopback rendering and private session-workspace storage. Keeping the implementation in the repository makes the guided experience discoverable and versioned alongside the existing version-3 requirements template without a hosted service or new package dependencies.
Behavior and boundaries
session.send. Proposals remain separate from confirmed answers until a human accepts them; rejection, cancellation and stale-reply checks preserve human edits.No cross-session draft library, link inspection/import, automatic full-document AI generation, publishing to GitHub/ADO, work-item creation, or design/planning/implementation workflow start. Supplied links are not inspected evidence. Human review is required for semantic correctness, completeness and accessibility.
Focused scope
Cherry-picked only
9234b75347f8314b25f3c841179927b88540e9ee, retaining its Copilot App co-author trailer, onto a fresh branch based onmaster. The complete diff contains exactly nine files in.github/extensions/RequirementsBuilder/plus the root README discovery paragraph: 10 files, 1,277 insertions. No Android/nested-repository changes, private illustrative drafts, demo exports, screenshots or transient HTTP tokens are included.Validation
Rerun in this isolated worktree:
Results: 25 tests passed; zero failed, skipped or cancelled. All six module syntax checks passed. Whitespace checks passed, and the complete branch diff matches the 10-file scope above.
The coordinating session additionally reported actual runtime loading and browser verification of save/resume, AI admission/propose/accept/reject, immediate stale warnings and disabled Accept while preserving input focus, table editing, non-UI applicability, and exact privately persisted Markdown export. Those interactive checks were not independently rerun in this publication worktree. Automated tests use a mocked conversation sender; no paid semantic-quality evaluation or formal accessibility audit was performed. Android builds are outside this extension-only scope.
Human review and tracking
Fixes AB#3822851
Tracking PBI: 3822851 - Add shared Requirements Builder canvas, under Android Client Software Factory, Feature 3797944. The PBI has a genuine Azure Boards GitHub pull-request artifact link to this PR.
This PR is ready for human review, not a claim of merge readiness. Required checks and human approval still apply; tracking linkage does not bypass them. Completing the tracking PBI is not deployment or rollout approval. This PR does not modify the previous merged PR or enable automatic merge.