Repository navigation
Temporarily skip CIAM certificate E2E tests after certificate rotation - #988
Merged
Gladwin Johnson VR (gladjohn) merged 1 commit intoNov 13, 2026
Merged
Conversation
Skip only the standard and custom-domain CIAM client-credentials tests while their rotated test certificate registration cannot be updated. Re-enable after the app certificate registration is repaired. Keep both CIAM ROPC tests and all production code unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 30f6db0b-e29c-474d-8fba-b560bd96f1bf
Gladwin Johnson VR (gladjohn)
requested a review
from a team
as a code owner
November 13, 2026 17:35
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the narrowly scoped, temporary skips of the two CIAM certificate tests.
No open issues 🎉
What changed in this PR
Temporarily skips the two CIAM certificate-based end-to-end tests blocked by certificate registration after rotation, without changing production code or other tests.
Changes:
- Adds method-level
unittest.skipdecorators to the certificate tests inCiamTestCaseandCiamCudTestCase. - Records
AADSTS700027and the re-enable condition: update the application’s certificate registration. - Leaves both CIAM ROPC tests enabled.
| File | Description |
|---|---|
tests/test_e2e.py |
Temporarily skips exactly two CIAM certificate tests with explicit re-enable conditions. |
Review effort: Balanced
Avery-Dunn
approved these changes
Nov 13, 2026
Gladwin Johnson VR (gladjohn)
added a commit
that referenced
this pull request
Nov 14, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6fe4a5cf-79f6-48f9-aa71-bd8af58c504b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily skip exactly the two CIAM certificate-based E2E tests failing with
AADSTS700027after test-certificate rotation:CiamTestCase.test_ciam_acquire_token_for_clientCiamCudTestCase.test_ciam_acquire_token_for_clientThe rotated certificate is not registered on the CIAM test application and that registration cannot currently be updated. Each method uses the existing
unittest.skipconvention with an explicit re-enable condition: restore the app certificate registration.Both CIAM ROPC tests remain enabled. No class-wide skips, error swallowing, production changes, or changes to other E2E tests.
Validation
unittest, bypassing class-level live-lab setup: exactly two skips with the newAADSTS700027reason; no failures or errors.git diff --checkpasses. Live tenant authentication was not run.