Skip to content

Temporarily skip CIAM certificate E2E tests after certificate rotation - #988

Merged
Gladwin Johnson VR (gladjohn) merged 1 commit into
devfrom
gladjohn/skip-ciam-certificate-e2e
Nov 13, 2026
Merged

Gladwin Johnson VR (gladjohn) merged 1 commit into
devfrom
gladjohn/skip-ciam-certificate-e2e

Conversation

@gladjohn

Copy link
Copy Markdown
Contributor

Summary

Temporarily skip exactly the two CIAM certificate-based E2E tests failing with AADSTS700027 after test-certificate rotation:

  • CiamTestCase.test_ciam_acquire_token_for_client
  • CiamCudTestCase.test_ciam_acquire_token_for_client

The rotated certificate is not registered on the CIAM test application and that registration cannot currently be updated. Each method uses the existing unittest.skip convention with an explicit re-enable condition: restore the app certificate registration.

Both CIAM ROPC tests remain enabled. No class-wide skips, error swallowing, production changes, or changes to other E2E tests.

Validation

  • Ran both test cases directly through unittest, bypassing class-level live-lab setup: exactly two skips with the new AADSTS700027 reason; no failures or errors.
  • Confirmed neither CIAM class nor either ROPC method is marked skipped.
  • Targeted pytest collection/run also reports two skips, but this local environment's missing lab credentials trigger its existing setup skip; that result is not used as proof of the new decorators.
  • git diff --check passes. Live tenant authentication was not run.

Skip only the standard and custom-domain CIAM client-credentials tests
while their rotated test certificate registration cannot be updated.
Re-enable after the app certificate registration is repaired.
Keep both CIAM ROPC tests and all production code unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 30f6db0b-e29c-474d-8fba-b560bd96f1bf
Copilot AI balanced review requested due to automatic review settings November 13, 2026 17:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the narrowly scoped, temporary skips of the two CIAM certificate tests.

No open issues 🎉

What changed in this PR

Temporarily skips the two CIAM certificate-based end-to-end tests blocked by certificate registration after rotation, without changing production code or other tests.

Changes:

  • Adds method-level unittest.skip decorators to the certificate tests in CiamTestCase and CiamCudTestCase.
  • Records AADSTS700027 and the re-enable condition: update the application’s certificate registration.
  • Leaves both CIAM ROPC tests enabled.
File Description
tests/​test_e2e.py Temporarily skips exactly two CIAM certificate tests with explicit re-enable conditions.

Review effort: Balanced

@gladjohn
Gladwin Johnson VR (gladjohn) merged commit e86a1aa into dev Nov 13, 2026
8 checks passed
Gladwin Johnson VR (gladjohn) added a commit that referenced this pull request Nov 14, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6fe4a5cf-79f6-48f9-aa71-bd8af58c504b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants