Repository navigation
Allow retries after failed resized image downloads - #534
Open
rahulshahDEV wants to merge 3 commits into
Open
rahulshahDEV wants to merge 3 commits into
rahulshahDEV wants to merge 3 commits into
Conversation
rahulshahDEV
force-pushed
the
fix/439-retry-resized-image-download
branch
3 times, most recently
from
November 3, 2026 07:29
f7b5b24 to
50854c7
Compare
rahulshahDEV
force-pushed
the
fix/439-retry-resized-image-download
branch
from
November 5, 2026 08:36
50854c7 to
d1150ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix.
When a resized-image download fails, its completed broadcast stream remains in
_runningResizes. A later request for the same image and dimensions reuses that stream and receives no response, so retrying does not load the image.🆕 What is the new behavior (if this is a feature change)?
The in-flight resize entry is removed when its stream emits an error or completes. Errors still reach the caller, and an identity check prevents an old stream from removing a newer retry. A later request can download the image again.
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
dart format --set-exit-if-changed .,flutter analyze, andflutter test --coveragepassed with Flutter 3.47.4 (147 tests). All platform example CI builds passed on this head.📝 Links to relevant issues/docs
Fixes #439. Related symptom: Baseflow/flutter_cached_network_image#980.
🤔 Checklist before submitting