Repository navigation
xml BUGFIX reject character references that overflow - #2623
Merged
Merged
Conversation
The code point of a character reference was accumulated in a uint32_t without a bound, so a reference with enough digits wrapped around before ly_pututf8() checked its range. � and � were both decoded to '<' instead of being rejected as out of range.
Member
|
Thanks, looks fine, but I have changed the target branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lyxml_parse_value() accumulated the code point of
&#...;and&#x...;references in a uint32_t with no bound, so�or�wrapped around and decoded to<(any other character can be produced the same way) where libxml2 and expat reject them as out of range; it now fails with the existing invalid character reference error once the value is past 0x10ffff and more digits follow, so leading zeros keep working.