Repository navigation
Update appVersion to 2.43.1 - #295
github-actions[bot] wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 57d9c3a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Helm template coverage
Uncovered detailscharts/clickstack/templates/NOTES.txtUncovered lines: none Uncovered branches: 37:default:fallback charts/clickstack/templates/_helpers.tplUncovered lines: 17 Uncovered branches: 111:or(1):true, 128:range:empty, 159:default:fallback, 160:or(1):true, 16:if:true, 176:if:false, 244:range:empty, 265:range:empty charts/clickstack/templates/additional-manifests.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/cluster.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/clickhouse/keeper.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/cronjob-check-alerts.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-configmap.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yamlUncovered lines: none Uncovered branches: 40:range:empty charts/clickstack/templates/hyperdx/deployment.yamlUncovered lines: none Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 26:default:fallback, 41:if:false, 42:with:empty charts/clickstack/templates/hyperdx/hpa.yamlUncovered lines: none Uncovered branches: 16:with:empty charts/clickstack/templates/hyperdx/ingress.yamlUncovered lines: none Uncovered branches: 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true charts/clickstack/templates/hyperdx/networkpolicy.yamlUncovered lines: none Uncovered branches: 11:with:empty charts/clickstack/templates/hyperdx/pdb.yamlUncovered lines: none Uncovered branches: 10:with:empty charts/clickstack/templates/hyperdx/secret.yamlUncovered lines: none Uncovered branches: 1:or(2):true, 1:or(3):true charts/clickstack/templates/hyperdx/service.yamlUncovered lines: none Uncovered branches: 14:default:fallback, 9:with:empty charts/clickstack/templates/hyperdx/serviceaccount.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/community.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/mongodb/password-secret.yamlUncovered lines: none Uncovered branches: none charts/clickstack/templates/otel-collector/custom-config.yamlUncovered lines: none Uncovered branches: none |
Deep Review✅ No critical issues found. This PR bumps Verification performed against the diff:
Reviewers (4): correctness, testing, maintainability, project-standards. Testing gaps: No helm-unittest test asserts the default |
App version bump PRs fail Helm Chart Tests because the `docs-check` added in #232 finds a stale `charts/clickstack/README.md`. The otel-collector image tag appears in the README, and the bump workflow never regenerates it, so #295 had to be fixed by hand. Both automated PR flows now run `make docs` before they open their PR. - The update-app-version workflow regenerates the README after bumping the tag. - The `version` script that changesets/action runs now ends with `make docs`. The release PR bumps the chart `version`, which shows in the README version badge, so the next release PR would have failed the same way. The chart itself doesn't change. `make docs` downloads helm-docs into `.tools/`, which is gitignored, so neither PR picks up the binary.
…43.1 # Conflicts: # charts/clickstack/README.md
This PR updates the appVersion in Chart.yaml to
2.43.1and aligns the otel-collector image tag in values.yaml.charts/clickstack/Chart.yamlotel-collector.image.tagincharts/clickstack/values.yaml