Skip to content

Update appVersion to 2.43.1 - #295

Closed
github-actions[bot] wants to merge 5 commits into
mainfrom
update-app-version-2.43.1
Closed

github-actions[bot] wants to merge 5 commits into
mainfrom
update-app-version-2.43.1

Conversation

@github-actions

@github-actions github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This PR updates the appVersion in Chart.yaml to 2.43.1 and aligns the otel-collector image tag in values.yaml.

  • Updated charts/clickstack/Chart.yaml
  • Updated otel-collector.image.tag in charts/clickstack/values.yaml

@github-actions
github-actions Bot requested a review from a team as a code owner November 1, 2026 21:24
@changeset-bot

changeset-bot Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 57d9c3a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

teeohhem
teeohhem previously approved these changes Nov 5, 2026
@teeohhem
teeohhem enabled auto-merge (squash) November 5, 2026 18:52
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Helm template coverage

Metric Value
Line coverage 99.85%
Branch coverage 91.54%
Line threshold 99% (met)
Branch threshold 90% (met)
Uncovered details

charts/clickstack/templates/NOTES.txt

Uncovered lines: none

Uncovered branches: 37:default:fallback

charts/clickstack/templates/_helpers.tpl

Uncovered lines: 17

Uncovered branches: 111:or(1):true, 128:range:empty, 159:default:fallback, 160:or(1):true, 16:if:true, 176:if:false, 244:range:empty, 265:range:empty

charts/clickstack/templates/additional-manifests.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/clickhouse/cluster.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/clickhouse/keeper.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/configmap.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/cronjob-check-alerts.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/dashboard-configmap.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/hyperdx/dashboard-provisioner-rbac.yaml

Uncovered lines: none

Uncovered branches: 40:range:empty

charts/clickstack/templates/hyperdx/deployment.yaml

Uncovered lines: none

Uncovered branches: 121:default:fallback, 131:default:fallback, 196:default:fallback, 201:with:empty, 20:with:empty, 26:default:fallback, 41:if:false, 42:with:empty

charts/clickstack/templates/hyperdx/hpa.yaml

Uncovered lines: none

Uncovered branches: 16:with:empty

charts/clickstack/templates/hyperdx/ingress.yaml

Uncovered lines: none

Uncovered branches: 35:if:false, 40:range:empty, 45:range:empty, 48:with:empty, 54:range:empty, 58:range:empty, 59:or(2):true, 59:or(3):true

charts/clickstack/templates/hyperdx/networkpolicy.yaml

Uncovered lines: none

Uncovered branches: 11:with:empty

charts/clickstack/templates/hyperdx/pdb.yaml

Uncovered lines: none

Uncovered branches: 10:with:empty

charts/clickstack/templates/hyperdx/secret.yaml

Uncovered lines: none

Uncovered branches: 1:or(2):true, 1:or(3):true

charts/clickstack/templates/hyperdx/service.yaml

Uncovered lines: none

Uncovered branches: 14:default:fallback, 9:with:empty

charts/clickstack/templates/hyperdx/serviceaccount.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/mongodb/community.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/mongodb/password-secret.yaml

Uncovered lines: none

Uncovered branches: none

charts/clickstack/templates/otel-collector/custom-config.yaml

Uncovered lines: none

Uncovered branches: none

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Deep Review

✅ No critical issues found.

This PR bumps appVersion and the bundled otel-collector image tag from 2.39.1 to 2.43.1. The diff is a pure value/metadata change with no template-logic changes, and every edit matches the output of .github/workflows/update-app-version.yml exactly (Chart.yaml edit, values.yaml tag edit, make docs README regeneration, and the "helm-charts": patch changeset).

Verification performed against the diff:

  • Rendering is unaffected. The command-selection logic in charts/clickstack/templates/hyperdx/cronjob-check-alerts.yaml gates on semverCompare thresholds 2.7.0 and 2.22.0; both 2.39.1 and 2.43.1 sit above 2.22.0, so the bump crosses no branch. The helm-coverage bot on the PR head reports 99.85% line / 91.24% branch coverage with thresholds met, confirming templates render.
  • No test breaks. The only remaining 2.39.1 reference in tests, charts/clickstack/tests/task-checkAlerts_test.yaml:248, is an explicit set: input exercising version-gated command rendering, not an assertion of the chart default. hyperdx-rollout-checksums_test.yaml:11 pins appVersion: 2.36.0 via a chart: override, and helpers_test.yaml:56 asserts a semver regex. None assert the chart default equals the old version.
  • Values are consistent. appVersion, the otel-collector image.tag, and the autogenerated README.md are all aligned to 2.43.1; the HyperDX image default (tag | default .Chart.AppVersion) resolves to 2.43.1 in lockstep.
  • Changeset is correct. Package name helm-charts matches package.json, and the patch level matches the established convention for prior appVersion bumps (2.36.0, 2.38.0, 2.39.1 were all patch changes). The chart version (3.5.0) is intentionally left for the changesets release workflow to bump.
  • No upgrade note required. docs/UPGRADE.md is keyed by chart version and only documents releases needing operator action; an appVersion patch bump that triggers a normal rolling update needs no entry, consistent with prior appVersion-only bumps.

Reviewers (4): correctness, testing, maintainability, project-standards.

Testing gaps: No helm-unittest test asserts the default appVersion or the otel-collector image.tag value, so the bumped literals have no direct assertion — this is pre-existing and by design (asserting static version literals would be a change-detector test), not a gap introduced by this PR.

jordan-simonovski added a commit that referenced this pull request Nov 10, 2026
App version bump PRs fail Helm Chart Tests because the `docs-check`
added in #232 finds a stale `charts/clickstack/README.md`. The
otel-collector image tag appears in the README, and the bump workflow
never regenerates it, so #295 had to be fixed by hand. Both automated PR
flows now run `make docs` before they open their PR.

- The update-app-version workflow regenerates the README after bumping
the tag.
- The `version` script that changesets/action runs now ends with `make
docs`. The release PR bumps the chart `version`, which shows in the
README version badge, so the next release PR would have failed the same
way.

The chart itself doesn't change. `make docs` downloads helm-docs into
`.tools/`, which is gitignored, so neither PR picks up the binary.
…43.1

# Conflicts:
#	charts/clickstack/README.md
auto-merge was automatically disabled November 12, 2026 21:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants