Repository navigation
chore(deps): add resolution floors for advisories in transitive deps #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,6 +78,21 @@ | |
| "@types/express": "4.17.21", | ||
| "@types/express-serve-static-core": "4.17.43", | ||
| "express": "^4.20.0", | ||
| "lodash": "4.18.1", | ||
| "qs": "^6.16.0", | ||
| "minimatch@3.1.2": "^3.1.4", | ||
| "minimatch@^3.0.4": "^3.1.4", | ||
| "minimatch@^3.1.1": "^3.1.4", | ||
| "minimatch@^3.1.2": "^3.1.4", | ||
| "minimatch@^8.0.2": "^8.0.6", | ||
| "minimatch@^9.0.4": "^9.0.7", | ||
| "minimatch@^9.0.5": "^9.0.7", | ||
| "minimatch@^10.2.2": "^10.2.3", | ||
| "picomatch@^4.0.2": "^4.0.4", | ||
| "picomatch@^4.0.3": "^4.0.4", | ||
| "@hono/node-server": "^1.19.13", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 minor — Overrides for Limit these to the ranges actually requested today, as the minimatch/picomatch lines do: Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond |
||
| "protobufjs": "^7.6.3", | ||
| "smol-toml@1.6.1": "^1.8.0", | ||
| "send": "^0.19.0", | ||
| "serve-static": "^1.16.0", | ||
| "cookie": "^0.7.0", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 minor — The
lodashoverride is an exact version, not a minimum like the other entriesChange it to
"lodash": "^4.18.1". The exact4.18.1forces every lodash request to that version, including the workspace's own^4.18.1requests (yarn.lock ~4819/4938/5042). If a later 4.18.x or 4.19.x security release comes out, or a dependency starts asking for one, Yarn will still install 4.18.1 andyarn upcannot move it.Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond