Repository navigation
Fix approximation of number of distinct values (replay of crate/crate#20565) - #1
Open
Svilen-Stefanov wants to merge 4 commits into
Open
Svilen-Stefanov wants to merge 4 commits into
Svilen-Stefanov wants to merge 4 commits into
Conversation
CodeBoarding reviewStatus: 4 changed components See the full change in CodeBoarding. Compared against the merge base: this branch is 3 commits behind graph LR
n_Database_Core_Engine["Database Core Engine"]
n_Content_Serialization_and_Extensions["Content Serialization and Extensions"]
n_Plugin_Registration_Modules["Plugin Registration Modules"]
n_Blackbox_Test_Suite["Blackbox Test Suite"]
n_Development_Tooling_Scripts["Development Tooling Scripts"]
n_Database_Core_Engine -- "instantiates and configures providers in" --> n_Content_Serialization_and_Extensions
n_Database_Core_Engine -- "loads copy and discovery extensions from" --> n_Plugin_Registration_Modules
n_Content_Serialization_and_Extensions -- "invokes functional helpers in" --> n_Database_Core_Engine
n_Plugin_Registration_Modules -- "registers engine modules with" --> n_Database_Core_Engine
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Database_Core_Engine modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replay of crate#20565 inside CodeBoarding's fork, to review it with CodeBoarding.
69b5f0a, unchanged.31875da, plus one commit that keeps only the CodeBoarding review workflow (crate's own CI is removed on this base branch).CodeBoarding/CodeBoarding-action@test/crate-java27, which installs Core fromCodeBoarding/CodeBoarding@perf/java-large-repo-queries(JDK runtime and JDT LS fixes from fix(java): resolve JDK types in projects targeting a newer Java than JDTLS runs on CodeBoarding#674 and perf(java): ask JDTLS for implementations and type hierarchy only where they exist CodeBoarding#675, not yet released).🤖 Generated with Claude Code