Repository navigation
Conversation
the upload page never sends a thumbnail, and when one was sent the service passed the full pdf url to uploadThumbnail, so the object was saved under a name like https://storage.googleapis.com/<bucket>/....png remove the thumbnail field from the route, the service and gcp storage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Purpose
The upload page never sends a thumbnail, and when one was sent, the service passed the full PDF URL to
uploadThumbnail, so the thumbnail was saved under an object literally namedhttps://storage.googleapis.com/<bucket>/....png.Corresponding issue: closes #553
🖼️ Showcase
no UI change atall Upload checks still return the same responses, and
pnpm buildpasses.🔧 Changes
thumbnailfield from/api/upload,uploadPaperandsrc/lib/storage/gcp.tsthumbnail_url: null, as before when no thumbnail was sentthumbnail_urlfrom the upload response type on the upload page (it was never read)➕ Additional Notes
unapproved/<id>.png) using the object path rather than the URL