Repository navigation
Conversation
two requests right after the cutoff could both see an old lastSyncedDate and both rebuild the list, leaving duplicate subjects or an empty list between the delete and the insert. claim the day with an atomic update first, and insert the new subjects before deleting the old ones
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Purpose
Requests that arrive together right after the cutoff could all see an old
lastSyncedDateand all rebuild the upcoming list. That left duplicate subjects, or briefly an empty list (404) between the delete and the insert.Corresponding issue: closes #556
🖼️ Showcase
20 simultaneous requests to
/api/upcoming-paperson a local copy (3 runs each)🔧 Changes
-the day is claimed with an atomic
findOneAndUpdateonlastSyncedDate; only the request that wins rebuilds the list➕ Additional Notes
UpcomingSlotdocument yet) still uses the upsert as before