Repository navigation
Conversation
user-papers passed any json body straight into $in, so a non array or invalid json became a 500. check it is a list of up to 100 subject names with zod. upload now returns 400 when a files entry is text instead of a file, and when more than one pdf is sent instead of quietly dropping the rest
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Purpose
/api/user-paperspassed any JSON body straight into$in, so a non-array body or invalid JSON became a 500./api/uploadcast everyfilesentry toFile, so a text value became a 500, and extra PDFs were silently droppedCorresponding issue: closes #557
🖼️ Showcase
POST /api/user-paperswith{}or invalid JSON: 500 -> 400POST /api/uploadwithfiles=hello: 500 -> 400POST /api/uploadwith two PDFs andisPdf=true: silently uses the first -> 400🔧 Changes
/api/user-papers: a list of up to 100 subject names/api/uploadrejects text entries infilesand more than one PDF➕ Additional Notes