Skip to content

mctpd: fix D-Bus Properties interface spelling - #182

Merged
jk-ozlabs merged 1 commit into
CodeConstruct:mainfrom
chilung-cgu:fix/mctpd-dbus-properties-typo
Nov 6, 2026
Merged

jk-ozlabs merged 1 commit into
CodeConstruct:mainfrom
chilung-cgu:fix/mctpd-dbus-properties-typo

Conversation

@chilung-cgu

Copy link
Copy Markdown
Contributor

The default D-Bus policy allows property reads through Properties.Get and Properties.GetAll, but misspells the interface as Propeties. Correct both send_interface values so the existing allow rules match, while preserving the default deny and privileged method-call policy.

Tests: Not run (configuration spelling correction).

Assisted-by: Codex:GPT-6 [GitHub MCP]

Copilot AI balanced review requested due to automatic review settings November 6, 2026 02:18

This comment was marked as spam.

@SafetyInObscurity

Copy link
Copy Markdown
Contributor

Ouch, thanks for the catch and apologies for the headache this may have caused

@jk-ozlabs

Copy link
Copy Markdown
Member

Hi!

The change looks correct, thanks for that.

However, one nit: from the the contribution guide:

Each commit message must include a Signed-off-by line, which indicates that you (the contributor) have certified the Developer Certificate of Origin v1.1 (DCO). This line must include the full name you commonly use, often a given name and a family name or surname, and should match the author metadata on the commit (ok: Sam Samuelsson, Robert A. Heinlein; not ok: xXthorXx, Sam, RAH)

Could you change this to the full name you commonly use?

Also, if you can set your name in your git config, that will give us proper metadata in the commit log, rather than just a username.

Correct the interface name used by the Get and GetAll allow rules.

Signed-off-by: Chi-Lung Wu <b0423031@gmail.com>
@chilung-cgu
chilung-cgu force-pushed the fix/mctpd-dbus-properties-typo branch from 4db0ec8 to 9ae7d61 Compare November 6, 2026 04:22
@chilung-cgu

Copy link
Copy Markdown
Contributor Author

Thanks, I’ve updated the commit author and Signed-off-by to Chi-Lung Wu, and pushed the update.

@jk-ozlabs

Copy link
Copy Markdown
Member

Superb, thanks!

@jk-ozlabs
jk-ozlabs merged commit 9ae7d61 into CodeConstruct:main Nov 6, 2026
4 checks passed
@jk-ozlabs

Copy link
Copy Markdown
Member

Merged, and also backported to the 2.6 stable branch. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants