Repository navigation
mctpd: fix D-Bus Properties interface spelling - #182
Conversation
|
Ouch, thanks for the catch and apologies for the headache this may have caused |
|
Hi! The change looks correct, thanks for that. However, one nit: from the the contribution guide:
Could you change this to the full name you commonly use? Also, if you can set your name in your git config, that will give us proper metadata in the commit log, rather than just a username. |
Correct the interface name used by the Get and GetAll allow rules. Signed-off-by: Chi-Lung Wu <b0423031@gmail.com>
4db0ec8 to
9ae7d61
Compare
|
Thanks, I’ve updated the commit author and Signed-off-by to Chi-Lung Wu, and pushed the update. |
|
Superb, thanks! |
|
Merged, and also backported to the 2.6 stable branch. Thanks for the contribution. |
The default D-Bus policy allows property reads through Properties.Get and Properties.GetAll, but misspells the interface as
Propeties. Correct bothsend_interfacevalues so the existing allow rules match, while preserving the default deny and privileged method-call policy.Tests: Not run (configuration spelling correction).
Assisted-by: Codex:GPT-6 [GitHub MCP]