Repository navigation
feat: check proxmox creation status and fail if it fails - #226
Open
BigSpaceships wants to merge 1 commit into
Open
BigSpaceships wants to merge 1 commit into
BigSpaceships wants to merge 1 commit into
Conversation
![datadog-computersciencehouse[bot]](https://avatars.githubusercontent.com/u/318130?s=60&v=4){kind=small}
| status = get_task_status(proxmox, task_id) | ||
|
|
||
| if status['status'] == 'stopped' and status['exitstatus'] != 'OK': | ||
| logging.warning('Failed to provision, error code is {}'.format(status['exitstatus'])) |
There was a problem hiding this comment.
🟡 Low: Code Quality Violation
do not use format with logging (...read more)
Avoid using format string with the format method when logging information.
Helpful? 👍/👎 
🚩 Report as false positive. Flags the rule for review to improve detection accuracy.
| status = get_task_status(proxmox, task_id) | ||
|
|
||
| if status['status'] == 'stopped' and status['exitstatus'] != 'OK': | ||
| logging.warning('Failed to provision, error code is {}'.format(status['exitstatus'])) |
There was a problem hiding this comment.
🟡 Low: Code Quality Violation
do not use format with logging (...read more)
Avoid using format string with the format method when logging information.
Helpful? 👍/👎
🚩 Report as false positive. Flags the rule for review to improve detection accuracy.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Checks to see if the vm creation task in proxmox fails, and if it does, send that error code back to the user. Also added watch support to hacking
Why
right now it fails silently and takes forever to fail
Test Plan
Lots of local testing
Env Vars
Nope
Documentation
Nope
Checklist