Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 79.50% 79.43% -0.07%
==========================================
Files 13 13
Lines 2132 2125 -7
==========================================
- Hits 1695 1688 -7
Misses 437 437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fajinyuan
previously approved these changes
Oct 21, 2026
As the instrument name is used as the extension by default it doesn't make sense to store the same value for both. When updating a configuration, the field is skipped or reset if it matches but when creating a new configuration, the matching extension would still be set. This makes the behaviour consistent between updating a configuration and creating a new one.
tpoliaw
force-pushed
the
matching-extension
branch
from
November 11, 2026 09:08
5736fb9 to
ea997de
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the instrument name is used as the extension by default it doesn't
make sense to store the same value for both. When updating a
configuration, the field is skipped or reset if it matches but when
creating a new configuration, the matching extension would still be set.
This makes the behaviour consistent between updating a configuration and
creating a new one.