Repository navigation
feat(kms)!: archive each root epoch's attestation and move the keyring to keyring_dir - #1595
Merged
Merged
Conversation
…g to keyring_dir Key handover sent the root keys of every epoch but not the attestation produced when each was generated, and the single bootstrap-info.json was overwritten by a rotation and never written by a join or auto-bootstrap (#539), so the evidence of older epochs was lost. - KmsKeys gains `attestation`, one per epoch. The source fills it from its keyring; the receiver archives it as is and does not verify it, which is left to relying parties. Older sources send it empty. - Every epoch is stored alike under <keyring_dir>/epochs/<n>/ with its root-attestation; root-epoch is written last and marks a complete keyring. The newest epoch no longer lives at the top level, and bootstrap-info.json is gone: GetMeta.bootstrap_info reports the served epoch's attestation. - The keyring moves out of cert_dir into the new core.keyring_dir. It has no default, so a config cannot silently put the root keys on storage that is not persistent. Older on-disk layouts are not read: a KMS always starts from bootstrap or onboarding, never from another version's disk. Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
feat/kms-epoch-attestation
branch
from
November 17, 2026 03:55
b1a755b to
1a6dfad
Compare
The tutorials mounted one volume per state directory under /etc/kms. Keep certificates and the root keyring together in a single kms-data volume at /var/lib/kms instead, leaving /etc/kms to configuration: a volume over /etc/kms would freeze the kms.toml baked into the image at first start. Signed-off-by: Kevin Wang <wy721@qq.com>
Give keyring_dir a default in kms.toml rather than requiring it, and move cert_dir and the default listener TLS paths there too, so all mutable KMS state sits under one directory and /etc/kms holds only configuration. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Key handover sends the root keys of every epoch, but not the attestation produced when each was generated. The single
bootstrap-info.jsonis overwritten by a rotation and never written by a join or auto-bootstrap (#539), so the evidence of older epochs is lost.Changes
KmsKeysgainsattestation, one per epoch. The source fills it from its keyring; the receiver archives it as is without verifying it (relying parties verify). Older sources send it empty, and a missing attestation is read as empty.bootstrap-info.jsonis gone;GetMeta.bootstrap_inforeports the served epoch's attestation. Auto-bootstrap records it too.cert_dirto the newcore.keyring_dir. All mutable state now defaults to/var/lib/kms(keyring/,certs/, and the default listener TLS paths), leaving/etc/kmsto configuration; the tutorials persist it with a singlekms-datavolume. A deployment that persists/etc/kms/certsand relies on the defaults must persist/var/lib/kmsor set the paths (see CHANGELOG).Compatibility
The wire change is additive. Older on-disk layouts are not read: a KMS always starts from bootstrap or onboarding, never from another version's disk.
Closes #539