Skip to content

SSE API cleanup - #513

Draft
willmmiles wants to merge 4 commits into
mainfrom
es-privacy
Draft

willmmiles wants to merge 4 commits into
mainfrom
es-privacy

Conversation

@willmmiles

Copy link
Copy Markdown

Clean up the server side event API to make internal portions private; this strengthens some invariants allowing some additional checks to be dropped. Includes a simplification of AsyncEventSource::close() that reduces copying and duplication (though to be fair this is very likely a rarely used call.)

willmmiles and others added 4 commits November 15, 2026 11:50
A client can be disconnected with its report still queued. Skipping it left
the last handle to drop here, so its destructor reported the disconnect.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@willmmiles

Copy link
Copy Markdown
Author

Draft because I haven't thoroughly reviewed this yet and I probably won't get to it until tomorrow; figured I'd post the WIP up anyways.

@mathieucarbou

Copy link
Copy Markdown
Member

Draft because I haven't thoroughly reviewed this yet and I probably won't get to it until tomorrow; figured I'd post the WIP up anyways.

The changeset looks good to me!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants