Skip to content

Only send authentication to the origin of the base URL - #904

Merged
GrahamCampbell merged 1 commit into
12.1from
gitlab-origin-scoped-authentication
Nov 17, 2026
Merged

GrahamCampbell merged 1 commit into
12.1from
gitlab-origin-scoped-authentication

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Member

The authentication plugin added the PRIVATE-TOKEN, JOB-TOKEN or Authorization header, and SUDO when a sudo user is set, to every request passing through the client, whatever origin it was for, so the credential followed redirects, pagination links and absolute URLs to other hosts. GitLab documents that job artifact downloads may be redirected through a CDN on GitLab.com, and instances that serve artifacts from object storage redirect them there, and because storage services ignore these headers the request succeeds and nothing shows that they were sent. The plugin is now bound to the origin of the base URL and rebound by setUrl(), adds the headers only to requests for that origin, and removes its own credential from a request for another origin that already carries it, together with SUDO when that matches as well. Symfony's Psr18Client and HttplugClient follow redirects themselves and keep these non-standard headers, so the builder now switches that off where withOptions() is available, from symfony/http-client 6.2, and leaves redirects to the client's own handling; the caller's instance is not changed. Redirects within the origin keep the credential. A base URL whose server redirects to another scheme, host or port, most commonly http redirecting to https, is no longer authenticated after the redirect, so such configurations need the URL the server actually uses. Tracked as GHSA-9hx4-j425-r37q.

@GrahamCampbell
GrahamCampbell force-pushed the gitlab-origin-scoped-authentication branch from 9a3fe6d to abf6c86 Compare November 17, 2026 23:01
@GrahamCampbell
GrahamCampbell marked this pull request as ready for review November 17, 2026 23:04
@GrahamCampbell
GrahamCampbell merged commit 89fb17f into 12.1 Nov 17, 2026
16 checks passed
@GrahamCampbell
GrahamCampbell deleted the gitlab-origin-scoped-authentication branch November 17, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant