Repository navigation
Only send authentication to the origin of the base URL - #904
Merged
Merged
Conversation
GrahamCampbell
force-pushed
the
gitlab-origin-scoped-authentication
branch
from
November 17, 2026 23:01
9a3fe6d to
abf6c86
Compare
GrahamCampbell
marked this pull request as ready for review
November 17, 2026 23:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authentication plugin added the
PRIVATE-TOKEN,JOB-TOKENorAuthorizationheader, andSUDOwhen a sudo user is set, to every request passing through the client, whatever origin it was for, so the credential followed redirects, pagination links and absolute URLs to other hosts. GitLab documents that job artifact downloads may be redirected through a CDN on GitLab.com, and instances that serve artifacts from object storage redirect them there, and because storage services ignore these headers the request succeeds and nothing shows that they were sent. The plugin is now bound to the origin of the base URL and rebound bysetUrl(), adds the headers only to requests for that origin, and removes its own credential from a request for another origin that already carries it, together withSUDOwhen that matches as well. Symfony'sPsr18ClientandHttplugClientfollow redirects themselves and keep these non-standard headers, so the builder now switches that off wherewithOptions()is available, from symfony/http-client 6.2, and leaves redirects to the client's own handling; the caller's instance is not changed. Redirects within the origin keep the credential. A base URL whose server redirects to another scheme, host or port, most commonlyhttpredirecting tohttps, is no longer authenticated after the redirect, so such configurations need the URL the server actually uses. Tracked as GHSA-9hx4-j425-r37q.