Skip to content

Request pagination links from the base URL - #905

Merged
GrahamCampbell merged 1 commit into
12.1from
gitlab-pager-path-and-query
Nov 17, 2026
Merged

GrahamCampbell merged 1 commit into
12.1from
gitlab-pager-path-and-query

Conversation

@GrahamCampbell

Copy link
Copy Markdown
Member

ResultPager requested the URLs from the Link response header exactly as given. GitLab writes those links with the instance's external URL, so when the client is given a different address for the same instance, such as an internal hostname, a port behind a proxy, or http where the external URL is https, page two onwards went to the external URL, and with authentication now limited to the base URL's origin those requests would go out unauthenticated. The pager now requests only the path and query of a link, so every page goes to the base URL. A link without a path, a link that cannot be parsed and a link whose path would not be read as the same path again on its own, such as one starting with two slashes or one holding a colon followed by digits and a slash, are still requested as given, so no link is sent anywhere it was not sent before.

@GrahamCampbell
GrahamCampbell force-pushed the gitlab-pager-path-and-query branch from 5530945 to 3e9fb71 Compare November 17, 2026 23:02
@GrahamCampbell
GrahamCampbell force-pushed the gitlab-pager-path-and-query branch from 3e9fb71 to a4be0bf Compare November 17, 2026 23:07
@GrahamCampbell
GrahamCampbell marked this pull request as ready for review November 17, 2026 23:08
@GrahamCampbell
GrahamCampbell merged commit c684bb9 into 12.1 Nov 17, 2026
16 checks passed
@GrahamCampbell
GrahamCampbell deleted the gitlab-pager-path-and-query branch November 17, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant