Repository navigation
Request pagination links from the base URL - #905
Merged
Merged
Conversation
GrahamCampbell
force-pushed
the
gitlab-pager-path-and-query
branch
from
November 17, 2026 23:02
5530945 to
3e9fb71
Compare
GrahamCampbell
force-pushed
the
gitlab-pager-path-and-query
branch
from
November 17, 2026 23:07
3e9fb71 to
a4be0bf
Compare
GrahamCampbell
marked this pull request as ready for review
November 17, 2026 23:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResultPagerrequested the URLs from theLinkresponse header exactly as given. GitLab writes those links with the instance's external URL, so when the client is given a different address for the same instance, such as an internal hostname, a port behind a proxy, orhttpwhere the external URL ishttps, page two onwards went to the external URL, and with authentication now limited to the base URL's origin those requests would go out unauthenticated. The pager now requests only the path and query of a link, so every page goes to the base URL. A link without a path, a link that cannot be parsed and a link whose path would not be read as the same path again on its own, such as one starting with two slashes or one holding a colon followed by digits and a slash, are still requested as given, so no link is sent anywhere it was not sent before.