Repository navigation
Fix very long text not forcibly wrapping at its max width - #4019
Merged
TrueDoctor merged 2 commits intoNov 6, 2026
Merged
TrueDoctor merged 2 commits into
TrueDoctor merged 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 5/5
- This looks low risk to merge because the only flagged item is PR metadata (title style), not a behavioral change in the code.
- The reported issue is a process/compliance concern (remove
fix:and use sentence case), so user-facing runtime regression risk appears minimal. - Pay close attention to
node-graph/nodes/text/src/text_context.rs- verify no functional text-wrapping behavior changed beyond what the title-format check implies.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/nodes/text/src/text_context.rs">
<violation number="1" location="node-graph/nodes/text/src/text_context.rs:80">
P1: Custom agent: **PR title enforcement**
PR title uses a conventional commit prefix and starts with a lowercase word. Rename it to sentence case without the `fix:` prefix (e.g., "Fix very long text not forcibly wrapping at its max width").</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Annonnymmousss
changed the title
Annonnymmousss
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the text layout logic in text_context.rs by importing OverflowWrap and setting OverflowWrap::BreakWord as a default style property. This change ensures that text will wrap by breaking words when necessary. I have no feedback to provide.
Member
|
!build (Run ID 24163097135) |
|
Keavon
force-pushed
the
master
branch
2 times, most recently
from
April 29, 2026 12:16
f07c79b to
76938eb
Compare
Keavon
force-pushed
the
master
branch
2 times, most recently
from
May 17, 2026 14:37
4b7a823 to
847b8e9
Compare
timon-schelling
force-pushed
the
master
branch
2 times, most recently
from
May 17, 2026 15:37
15fcaac to
d5f0140
Compare
TrueDoctor
force-pushed
the
fix/text_box_constraint_breakage
branch
from
November 6, 2026 22:32
35b9098 to
38ea218
Compare
TrueDoctor
approved these changes
Nov 6, 2026
TrueDoctor
enabled auto-merge
November 6, 2026 22:38
Keavon
pushed a commit
that referenced
this pull request
Nov 6, 2026
* fix: Very long text does not forcibly wrap at its max width * Test that a word longer than the max width breaks to stay within it --------- Co-authored-by: Dennis Kobert <dennis@kobert.dev>
Keavon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4009
Screen.Recording.2026-04-09.at.4.05.43.AM.mov