Repository navigation
Report error location as "Line n, column n." - #682
Merged
Merged
Conversation
Replaces the "Occured at: line:column" suffix of located Handlebars exception messages with "Line n, column n.". The numbers are unchanged (zero-based, same as HandlebarsException.Line/Column). Refs #314 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Refs #314
Follow-up to #681, as requested on #314: located Handlebars exceptions now report their position as
Line n, column n.instead ofOccured at: n:n.Before:
After:
Details
HandlebarsException.Line/Column.Occured at:will no longer find it. TheLineandColumnproperties added in Expose error location on exceptions and show the source line with a caret #681 are the reliable way to read the position.Tests
The
ExceptionTestsassertions are updated to the new format. The full suite passes (2234 tests).🤖 Generated with Claude Code
Closes #314