Repository navigation
test blockserver restarts processes - #140
Draft
jackbdoughty wants to merge 2 commits into
Draft
jackbdoughty wants to merge 2 commits into
jackbdoughty wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Lets users who are in manager mode, restart individual server-side processes that before they would have had to do via a whole server restart. This is done by exposing two new PVs:
All server processes (except PSCTRL) are restarted (by the frontend) by writing their ioc name to CS:BLOCKSERVER:RESTART_SERVICE_IOC. Most of which are restarted by the blockserver. The 3 that are different are:
Unit tests are written at the blockserver and database server level. And there is a system test that checks that all service iocs can be restarted from the above PV.
To test, check out all linked PRs. You'll need to do a
python -m pip install -e . --no-depsfor server-common and just copy paste the inst-server changes to C:\instrument\apps\EPICS\ISIS\inst_servers\master. (atleast thats what I did). Make sure all tests pass and check for expected behaviour. Is their enough friction/informative enough on the front end for restarting processes?