Skip to content

Remove postinstall build and binary download - #44

Open
koterpillar wants to merge 3 commits into
JacobLinCool:mainfrom
koterpillar:remove-postinstall
Open

koterpillar wants to merge 3 commits into
JacobLinCool:mainfrom
koterpillar:remove-postinstall

Conversation

@koterpillar

@koterpillar koterpillar commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Remove the postinstall hook and build helper so package installation does not build JavaScript or download the native binary. README is updated to show binary installation before library use.

Stacked on #43. Merge that first. Review the changes added by this PR. The base remains upstream main because #43's branch is in a fork.

Why

npm 12 makes dependency install scripts opt-in. Bun restricts lifecycle scripts to trusted packages, and Deno requires explicit approval for dependency lifecycle scripts. Consumers can install this package without approving an install script.

Compatibility

CLI downloads on first use, explicit cloudflared bin install [version], library install(...), binary path overrides, and #43's version enforcement and optional updates remain intact. Published packages include compiled JavaScript and types.

Workflows that relied on install-time setup need these changes:

  • Library consumers must call await install(bin, {}) before creating a tunnel or installing a service, or supply an existing executable.

Includes a minor-version changeset for these setup requirements.

@changeset-bot

changeset-bot Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b19756e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cloudflared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koterpillar
koterpillar force-pushed the remove-postinstall branch 3 times, most recently from 6b0f661 to 67a551c Compare November 17, 2026 08:48
@koterpillar
koterpillar marked this pull request as ready for review November 17, 2026 09:59
koterpillar added a commit to atlassian-forks/node-cloudflared that referenced this pull request Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant