Repository navigation
Conversation
Reworked after the review of LeanBitLab#739: - No saved state is changed: a closed fine-tune section is opened only for the screen that shows the setting (in its back stack entry); a section the user opens or closes himself is as he wants from then on. - The long press is a normal combinedClickable on the preference, with an accessibility label, no pointer handling of its own. - No global object: the setting to show and the sections opened for it are kept in the SavedStateHandle of the target screen's back stack entry, the nav controller is passed down as a CompositionLocal. No timeout. - The setting itself is brought into view, also further down in a large card, and highlighted for a moment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VuiaMhLXwhErf9shhrr1uD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new version of #739, reworked after your review:
combinedClickableon the preference, with an accessibility label, so it also works with TalkBack. No pointer handling of its own.SavedStateHandleof the target screen's back stack entry; the nav controller is passed down as aCompositionLocal. No timeout.Tests:
SettingsJumpTest(the steps: open sections, keep only the one with the setting, give up). Also tested on an emulator: long press on a search result, the setting is shown and highlighted, and the saved section state is unchanged afterwards.