Repository navigation
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xdebug.inienabledxdebug.discover_client_hosttogether withstart_with_request=yes. WithXDEBUG_MODE=debug, every request made Xdebug open its debugger connection to the address taken from the request (X-Forwarded-FororREMOTE_ADDR) instead of the configuredclient_host. Anyone able to send a request to the environment could choose where the debugger session goes and receive a DBGp session, which allows evaluating arbitrary PHP in the container.This removes
xdebug.discover_client_host. Xdebug now always connects toclient_host=host.docker.internal, which the compose file already maps to the host gateway, so the documented IDE setup keeps working.XDEBUG_CONFIGcan still overrideclient_host.Validation
tests/proxy/compose-policy.batsfails onmainand passes with this change; the rest of the file still passes.XDEBUG_MODE=debug, a request carryingX-Forwarded-Forpointing to another container made Xdebug connect to that container onmain; with thisxdebug.inimounted, no connection was made.