Repository navigation
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PHP images run two installers downloaded at build time without any verification:
install-php-extensionsfrom thelatestrelease and the nvm installer from themasterbranch, piped intobash. The nginx image was built from the floatingnginx:alpinetag and is republished every night. A change upstream would end up in the published:latestimages without any review in this repository.This change:
install-php-extensions2.13.2 and the nvm v0.41.0 installer withADD --checksum, so the build fails if the content differs from the pinned SHA-256. The nvm installer is no longer piped into a shell.nginx:1.31.8-alpineby digest, which Dependabot already tracks under/.docker/.Validation
tests/proxy/compose-policy.batsfails onmainand passes with this change; the rest of the file still passes.Dockerfile.php83andDockerfile.nginxlocally: the PHP image installs the same 59 PHP modules and Node 24 with npm and nvm 0.41.0, and the installers are not left in the image.