Repository navigation
Unify URMA Jetty resource creation and ownership - #102
Open
Spicy-cream wants to merge 1 commit into
Open
Spicy-cream wants to merge 1 commit into
Spicy-cream wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
URMA startup preallocation and on-demand connection setup each construct the same JFCE, JFC, JFR, and Jetty. The paths also interpret queue-depth flags independently, so a prepared resource can be selected using current flags instead of the configuration it was created with.
What changed?
This is the first change in the Jetty resource pooling series. Used Jetty resources are still destroyed when their connection closes.
Validation
brpc_urma_unittest.Follow-up PRs for Jetty resource pooling
Steps 2 and 3 can proceed independently after this PR. Each follow-up will preserve existing unit tests and add focused cases as needed.