Skip to content

fix(renovate): group Diesel Rust dependencies - #1011

Open
ReenigneArcher wants to merge 1 commit into
masterfrom
codex/group-diesel-renovate
Open

ReenigneArcher wants to merge 1 commit into
masterfrom
codex/group-diesel-renovate

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Koko's separate Diesel and diesel_migrations updates cannot regenerate Cargo.lock because the new migrations release requires a compatible Diesel minor release while Diesel remains exactly pinned. See KokoStreamTV/Koko#373 and KokoStreamTV/Koko#374.

Add a Rust preset to the shared default configuration that groups the two Cargo dependencies into one Diesel PR. Match the package names exactly and limit the rule to Cargo so unrelated packages retain their existing grouping.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Testing

  • Extended the existing preset-resolution regression test to cover both Diesel crates, an unrelated Cargo dependency, and an npm package with the same name. Confirmed the regression fails before the configuration change and passes afterward.
  • All 229 tests in the 16 tracked test files passed with node --test using the paths returned by git ls-files -- 'tests/*.test.mjs'.
  • npm run validate-renovate -- renovate/rust.json5 and npm run validate-renovate -- renovate/default.json5 passed strict validation. The local validator used its RegExp fallback because optional RE2 is unavailable.
  • git diff --check passed.
  • The unfiltered npm test command also discovers unrelated test files under ignored local build directories and fails there. Those files are outside this change.
  • Hosted CI and a live Renovate run against the merged preset are pending.

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Tests have been added or updated for new or modified functionality, including regression tests for bug fixes

AI Usage

See our AI usage policy.

  • AI tools were used while preparing this PR

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant