Repository navigation
fix(tokio): reject DataRow with a field count that differs from the columns - #37
Merged
Merged
Conversation
…olumns Row/SimpleQueryRow validated the requested index against the RowDescription column count but indexed the ranges vector built from the DataRow field count, which the server controls independently. A DataRow with fewer fields than advertised columns made get/try_get (and a plain 0..row.len() loop) panic with an out-of-bounds index. Validate the two counts match when the row is built so the mismatch surfaces as a recoverable error instead.
jasonhernandez
approved these changes
Nov 12, 2026
With `use std::f32;` in scope, `f32::INFINITY` resolves to the deprecated module constant. Rust 1.99 warns on it, and CI's -Dwarnings turns that into a compile error in the clippy and test jobs. Upstream removed the same imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row/SimpleQueryRow validated the requested index against the RowDescription column count but indexed the ranges vector built from the DataRow field count, which the server controls independently. A DataRow with fewer fields than advertised columns made get/try_get (and a plain 0..row.len() loop) panic with an out-of-bounds index. Validate the two counts match when the row is built so the mismatch surfaces as a recoverable error instead.
Cherry-picked from upstream's 7a00ffa