Repository navigation
Fail pending input when an archive expires its Environment - #951
Merged
Merged
Conversation
An administrator archive expired the Environment and then cancelled the Session's pending input. A cancelled initial input on an openai_hosted Session projects no activity, so the Session read idle with no error and the caller could not learn that its input would never run. Compute expiry already failed the input first, so the same expiry read failed. Both now end the Environment through sessions.ExpireEnvironment: expire a live Environment, fail input that never ran, cancel active work. TerminateEnvironment fails a live Environment whose compute did not expire and expires every other one, which removes the three-way termination decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An administrator archive expired the Environment and then cancelled the
Session's pending input. A cancelled initial input on an openai_hosted
Session projects no activity, so the Session read idle with no error and
the caller could not learn that its input would never run. Compute expiry
already failed the input first, so the same expiry read failed.
Both now end the Environment through sessions.ExpireEnvironment: expire a
live Environment, fail input that never ran, cancel active work.
TerminateEnvironment fails a live Environment whose compute did not expire
and expires every other one, which removes the three-way termination
decision.
Tests:
go test ./internal/sessions ./internal/deployment; integrationTestManagedSessionArchive*,TestManagedEnvironmentTermination*,Archive|Resetsuites; api/execution/deploymentpg archive and reset tests.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.