Repository navigation
Unify the agent review gate - #966
Merged
Merged
Conversation
Agents choose one or two blind reviewers by risk, review follow-up changes only, stop after three rounds to reassess the design, and record findings they leave unfixed. Documentation changes are reviewed too, because docs/ and contracts/ hold protocol sources.
Address review: make CONTRIBUTING.md's Review section point to the gate, add the repository path and self-assessment rules, make data-integrity findings blocking, define what follows the third round, and clarify the reviewer triggers.
Address the second review: keep fixes and blocking findings within the task boundaries, take task boundaries from the user, define the severity scale and the uncommitted review range, and record the review gate in the ownership map.
Address the third review: split the end of the gate into two explicit cases, keep problems the change causes in scope, restore the contributor review paragraph, and tighten the review range and reviewer triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the one-line agent review rule with an independent review gate in
AGENTS.md, matching the gate used across the maintainer's other repositories and adapted to OpenAgentCore.docs/andcontracts/include protocol and contract sources.CONTRIBUTING.mdkeeps its review paragraph for contributors, points agents to the gate, and lists the gate in the ownership table.Reviewed in three blind rounds; all validated findings were fixed except the "blind review workflow" link label in
contracts/agents-api/harness-onboarding.md(and its Chinese mirror), which is outside this change.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.