Skip to content

Unify the agent review gate - #966

Merged
SaladDay merged 4 commits into
mainfrom
unify-the-agent-review-gate
Nov 12, 2026
Merged

SaladDay merged 4 commits into
mainfrom
unify-the-agent-review-gate

Conversation

@SaladDay

@SaladDay SaladDay commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Replace the one-line agent review rule with an independent review gate in AGENTS.md, matching the gate used across the maintainer's other repositories and adapted to OpenAgentCore.

  • One fresh blind reviewer by default; two when a change touches a protocol's code or document, database schema or migrations, authentication, credentials or isolation, or a shared lifecycle, admission, cancellation or reuse flow.
  • Follow-up rounds review only the changes since the last reviewed range, with one new reviewer.
  • At most three rounds; the gate ends either by finishing with medium/low findings listed, or by reassessing the design, with one corrected design allowed through the gate before stopping to report.
  • In-scope blocker, high-severity and data-integrity findings always block completion; problems outside the task boundaries are recorded and reported.
  • Documentation changes are reviewed too, because docs/ and contracts/ include protocol and contract sources.

CONTRIBUTING.md keeps its review paragraph for contributors, points agents to the gate, and lists the gate in the ownership table.

Reviewed in three blind rounds; all validated findings were fixed except the "blind review workflow" link label in contracts/agents-api/harness-onboarding.md (and its Chinese mirror), which is outside this change.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Agents choose one or two blind reviewers by risk, review follow-up changes only, stop after three rounds to reassess the design, and record findings they leave unfixed. Documentation changes are reviewed too, because docs/ and contracts/ hold protocol sources.
Address review: make CONTRIBUTING.md's Review section point to the gate, add the repository path and self-assessment rules, make data-integrity findings blocking, define what follows the third round, and clarify the reviewer triggers.
Address the second review: keep fixes and blocking findings within the task boundaries, take task boundaries from the user, define the severity scale and the uncommitted review range, and record the review gate in the ownership map.
@SaladDay
SaladDay merged commit 688b931 into main Nov 12, 2026
14 checks passed
@SaladDay
SaladDay deleted the unify-the-agent-review-gate branch November 12, 2026 18:44
Address the third review: split the end of the gate into two explicit cases, keep problems the change causes in scope, restore the contributor review paragraph, and tighten the review range and reviewer triggers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant