Repository navigation
Document closesOnNavigation() for plugin overlays - #612
Open
wojt-janowski wants to merge 1 commit into
Open
wojt-janowski wants to merge 1 commit into
wojt-janowski wants to merge 1 commit into
Conversation
NativePHP/mobile-air#670 lets a UI plugin element opt in to closing when its screen navigates away, like core bottom sheets and modals. Amp-Thread-ID: https://ampcode.com/threads/T-01a1dca0-9fd9-70ee-9a18-d0b2c7791ec9 Co-authored-by: Wojt Janowski <wojt@clinically.com.au>
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents
Element::closesOnNavigation()from NativePHP/mobile-air#670 in UI Component Plugins, as asked there.A new "Closing Overlays on Navigation" section, marked since 4.8, explains why open bottom sheets and modals close when a screen navigates away, and how a plugin's own sheet or modal opts in by returning
truefromclosesOnNavigation(). It also covers what the leaving screen's last frame contains, and that the element's$typemust match the manifest.Testing
php artisan test --filter=Documentation: 8 passed.