Repository navigation
feat(demo): three.js yard drawn as Meshes, a BatchedMesh and InstancedMeshes - #217
Merged
Merged
Conversation
…dMeshes The same parts on WebGPURenderer in three draw modes, switchable at run time, with fps, draw calls and render time reported once a second. It shows what batching saves on a scene that would otherwise issue one draw, bind group and uniform upload per part.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/demo/canvas-three/examples/webgpu_batched_mesh.ts: the same yard of parts onWebGPURendererin three draw modes, switchable at run time, reporting fps, per-frame draw calls and median render time once a second. Registered in the three demo list aswebgpu_batched_mesh, which cycles the modes every 10 s and logs the stats.Same scene on the Linux build (Intel, frames driven by a timer so fps is CPU-bound), median
renderer.render()time:BatchedMesh still issues one draw per visible part on WebGPU (three has no multi-draw there), but with no bind group, pipeline or uniform upload between them, so the per-part cost is the draw call alone.