Repository navigation
fix(webgpu): finish the wgpu sync port for napi and Windows - #220
Merged
Merged
Conversation
canvas-napi did not map the new snorm10-10-10-2 vertex format, and the dx12 texture_from_raw call was missing the new drop callback argument. Also adds the enum value to the generated C headers.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the wgpu sync port from #219. The Linux and Windows native builds failed on master:
snorm10-10-10-2vertex format (napi enum, both conversions, and theVERTEX_FORMATStable).drop_callbackargument (None) todx12::Device::texture_from_raw.canvas_native.hcopies.