Repository navigation
Fix Flamewood's Avenging Flame ignoring the supported skill's totem limit - #10444
Open
lucaskarsten wants to merge 2 commits into
Open
lucaskarsten wants to merge 2 commits into
lucaskarsten wants to merge 2 commits into
Conversation
…imit Avenging Flame is cast by the totems of the skill Flamewood supports, but its ActiveTotemLimit was summed from its own mod list. Skill-specific limits (e.g. +N Searing Bond totems from Foulborn The Searing Touch or gem quality) were lost, so "per maximum number of Summoned Totems" and "per Summoned Totem" mods scaled from the wrong count. Use the trigger source's cached limit.
CalcPerform takes the totem count for "per Summoned Totem" mods from the main skill's mod list before triggers run. With Avenging Flame selected it lost the supported skill's limit, so e.g. Ritual of Awakening regeneration or armour per totem dropped. Use the totem skill in the same socket group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10440 .
Description of the problem being solved:
Flamewood Support grants Avenging Flame, which is cast by the totems of the skill Flamewood supports.
CalcOffencesummed Avenging Flame'sActiveTotemLimitfrom Avenging Flame's own mod list, so totem limits tied to the supported skill were lost:+N to maximum number of Summoned Searing Bond Totems(Foulborn The Searing Touch) carries aSkillName = Searing Bondtag. As a result Conjoined Spire (more damage and more AoE per maximum totem) and Ritual of Awakening (more damage per summoned totem) scaled Avenging Flame from the wrong count, as reported in the issue.When a skill is granted by a support and has a trigger source (
SkillGrantedBySupport+triggerSourceUUID), the totem limit now comes from the source skill's cached output, the same cache entryCalcTriggersalready builds for it in the currentenv.mode. Avenging Flame is the onlySkillGrantedBySupportskill with the totem flag, so no other skill changes. The bleed stack count now reusesoutput.ActiveTotemLimitso both sites agree.A second commit fixes the defensive side.
CalcPerformsetsTotemsSummonedfor "per Summoned Totem" mods (Ritual of Awakening regeneration, armour per totem, enemy damage taken per totem) from the main skill's mod list, before triggers run. With Avenging Flame selected it used Avenging Flame's own count, so those stats dropped. When the main skill is support-granted, the limit now comes from the totem skill in the same socket group.Not changed: if several totem skills are linked to Flamewood, the trigger source stays the one with the highest totem life (existing
avenging flametrigger config), so the offensive limit follows the same skill the damage already uses.Steps taken to verify a working solution:
TestTriggers_spec.lua(Searing Bond + Flamewood,+4 Searing Bond totems, Conjoined Spire AoE line): before the fix Avenging Flame hadActiveTotemLimit1 vs 7 for Searing Bond; after,ActiveTotemLimit,TotemsSummonedandAreaOfEffectMod(1.7) match the source.+300 Armour per Summoned Totem: armour is 2100 with Searing Bond as the main skill; with Avenging Flame selected it was 300 before the second commit and is 2100 after.busted --lua=luajitin thepathofbuilding-testsimage: 668 successes / 1 failure. The failure isTestRareLike_spec.lua @ 80, which already fails ondevand is fixed by Fix TestRareLike spec failing after level requirement change #10417.Link to a build that showcases this PR:
https://pobb.in/J35egLGqk6al (from the issue)
Before screenshot:
See the issue: Avenging Flame shows 20% / 6% more damage.
After screenshot:
Avenging Flame uses the Searing Bond totem limit (spec above).