Repository navigation
Fix Energy Blade quality attack speed applying as more multiplier - #10448
Open
lucaskarsten wants to merge 1 commit into
Open
lucaskarsten wants to merge 1 commit into
lucaskarsten wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Energy Blade's quality stat
storm_blade_global_attack_speed_+%("Buff grants {0}% increased Attack Speed", 0.5 per quality) was mapped asEnergyBladeAttackSpeedMORE, which only multiplies the blade's base attack rate (CalcOffence.lua,AffectedByEnergyBladeblock). The stat is global increased attack speed, so it should add to the other increased attack speed sources instead of multiplying on top of them.It now uses the same mapping the other global attack speed buffs use:
mod("Speed", "INC", nil, ModFlag.Attack, 0, { type = "GlobalEffect", effectType = "Buff", unscalable = true }), in bothsrc/Export/Skills/act_int.txtand the generatedsrc/Data/Skills/act_int.lua. The item mod "Energy Blades have X% increased attack speed" still usesEnergyBladeAttackSpeedand is unchanged.Open question for review: I kept
unscalable = trueto match the rest of Energy Blade's statMap. If buff effect is meant to scale this like other attack speed buffs, it can be dropped.Steps taken to verify a working solution:
TestOffence_spec.lua: Energy Blade 20/20 vs 20/0 with Cleave and 100% increased Attack Speed now gives a 1.05 speed ratio ((1 + 1 + 0.1) / 2); it fails ondevwith 1.10.TestRareLike_spec.lua:84) also fails ondevwithout this change (Fix TestRareLike spec failing after level requirement change #10417 addresses it).Link to a build that showcases this PR:
Energy Blade with quality plus any increased Attack Speed.
Before screenshot:
Energy Blade 20/20, Cleave, 100% increased Attack Speed: 2.992 attacks per second (quality multiplies: 2.72 × 1.10).
After screenshot:
Same setup: 2.856 attacks per second (2.72 × 2.10 / 2.00).