Repository navigation
Add Wickerman item data and character import support - #10455
Open
AdamZ-8113 wants to merge 1 commit into
Open
AdamZ-8113 wants to merge 1 commit into
AdamZ-8113 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds support for importing Viscera from a character into PoB. This adds their item definitions and imports them into the four Wickerman equipment slots, keeping their names and modifiers when saving, reopening or reimporting a character.
** Dependencies**
This only works with the OAuth import route which uses the Character API. Import by Account name doesn't work because the website character viewer doesn't currently expose this data.
The four captured viscera have been checked against live data. Other definitions come from the preview spreadsheet and remain provisional. Greater variants and the three Artificial Appendages have synthetic test coverage but still need live examples. Ravenous Skull's corpse-consumption recovery text is imported, but its effect isn't calculated yet.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: