Repository navigation
fix: correct zh-Hans version names and add missing zh-Hant DLC names - #1713
Merged
Merged
Conversation
Naramsim
approved these changes
Nov 11, 2026
|
This Pull Request won't be deployed since the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Fixes the Chinese rows of
version_names.csv: 11 zh-Hans names that held Traditional text, and 4 missing zh-Hant rows.zh-Hans names written in Traditional characters
For these nine versions the zh-Hans row was identical to the zh-Hant row. The zh-Hant rows are unchanged.
redbluesilverrubysapphireemeraldfireredleafgreensoulsilverScarlet/Violet DLC versions
Versions 42, 43, 52 and 53 had a zh-Hans row but no zh-Hant row, and for The Indigo Disk (43, 53) the zh-Hans row held the Traditional text.
朱: 碧之假面, 43朱: 藍之圓盤, 52紫: 碧之假面, 53紫: 藍之圓盤The new rows use the same
<version>: <DLC>format as the existing zh-Hans rows and the Sword/Shield DLC rows.Source
Game text dumps at abcboy101/poke-corpus:
corpus/Champions/zh-Hans_ms.txtlists the series titles in Simplified Chinese: 宝可梦 红/绿, 宝可梦 金/银/水晶版, 宝可梦 红宝石/蓝宝石/绿宝石, 宝可梦 火红/叶绿, 宝可梦 心金/魂银.corpus/ScarletViolet/zh-Hans_common.txtandzh-Hant_common.txthave the DLC titles as 蓝之圆盘 / 藍之圓盤 (line idsv.ymap_mission_title.ymap_mission_title_main_SDC02) and 碧之假面 in both scripts.Blue (蓝) is not in the Champions list, which pairs Red with Green. It is the Simplified form of the existing zh-Hant name 藍.
How to test
Data-only change. Build the database (
make build-db) and check thenamesof/api/v2/version/1/and/api/v2/version/43/.AI coding assistance disclosure
I used Claude Code to find zh-Hans rows containing Traditional characters, compare them against the game text dumps, and apply the edits. I checked each changed row against the source myself.
Contributor check list