Skip to content

fix: correct zh-Hans version names and add missing zh-Hant DLC names - #1713

Merged
Naramsim merged 1 commit into
PokeAPI:masterfrom
Xdynix:fix/zh-version-names
Nov 12, 2026
Merged

Naramsim merged 1 commit into
PokeAPI:masterfrom
Xdynix:fix/zh-version-names

Conversation

@Xdynix

@Xdynix Xdynix commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Change description

Fixes the Chinese rows of version_names.csv: 11 zh-Hans names that held Traditional text, and 4 missing zh-Hant rows.

zh-Hans names written in Traditional characters

For these nine versions the zh-Hans row was identical to the zh-Hant row. The zh-Hant rows are unchanged.

Version Before After
1 red 紅 红
2 blue 藍 蓝
5 silver 銀 银
7 ruby 紅寶石 红宝石
8 sapphire 藍寶石 蓝宝石
9 emerald 綠寶石 绿宝石
10 firered 火紅 火红
11 leafgreen 葉綠 叶绿
16 soulsilver 魂銀 魂银

Scarlet/Violet DLC versions

Versions 42, 43, 52 and 53 had a zh-Hans row but no zh-Hant row, and for The Indigo Disk (43, 53) the zh-Hans row held the Traditional text.

  • 43, 53 zh-Hans: 藍之圓盤 → 蓝之圆盘
  • Added zh-Hant rows: 42 朱: 碧之假面, 43 朱: 藍之圓盤, 52 紫: 碧之假面, 53 紫: 藍之圓盤

The new rows use the same <version>: <DLC> format as the existing zh-Hans rows and the Sword/Shield DLC rows.

Source

Game text dumps at abcboy101/poke-corpus:

  • corpus/Champions/zh-Hans_ms.txt lists the series titles in Simplified Chinese: 宝可梦 红/绿, 宝可梦 金/银/水晶版, 宝可梦 红宝石/蓝宝石/绿宝石, 宝可梦 火红/叶绿, 宝可梦 心金/魂银.
  • corpus/ScarletViolet/zh-Hans_common.txt and zh-Hant_common.txt have the DLC titles as 蓝之圆盘 / 藍之圓盤 (line id sv.ymap_mission_title.ymap_mission_title_main_SDC02) and 碧之假面 in both scripts.

Blue (蓝) is not in the Champions list, which pairs Red with Green. It is the Simplified form of the existing zh-Hant name 藍.

How to test

Data-only change. Build the database (make build-db) and check the names of /api/v2/version/1/ and /api/v2/version/43/.

AI coding assistance disclosure

I used Claude Code to find zh-Hans rows containing Traditional characters, compare them against the game text dumps, and apply the edits. I checked each changed row against the source myself.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim Naramsim added the no-deploy Instructs the updater-bot not to deploy this PR label Nov 12, 2026
@Naramsim
Naramsim merged commit fd898a1 into PokeAPI:master Nov 12, 2026
8 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

This Pull Request won't be deployed since the label no-deploy was found in its meta-data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-deploy Instructs the updater-bot not to deploy this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants