Repository navigation
fix: update zh-Hans move, ability and item names renamed since BDSP - #1714
Merged
Merged
Conversation
Naramsim
approved these changes
Nov 11, 2026
Naramsim
left a comment
Member
There was a problem hiding this comment.
we can go with the new names, since they are the default now
|
This Pull Request won't be deployed since the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Updates 27 Simplified Chinese (zh-Hans) names to the ones the games have used since Brilliant Diamond / Shining Pearl. The current values are the Sun/Moon to Sword/Shield names.
move_names.csvability_names.csvitem_names.csvmimikium-z--held)mimikium-z--bag)Evidence
Game text dumps at abcboy101/poke-corpus (
corpus/<Game>/zh-Hans_*.txt, sectionswazaname,tokuseianditemname).For every entry except Mimikium Z:
zh-Hans-CN_common.txt) already uses the new names.Mimikium Z follows the species rename 谜拟Q → 谜拟丘. Its new name is in Brilliant Diamond/Shining Pearl, Legends: Arceus, Legends: Z-A and HOME; Scarlet/Violet still has the old one.
PKHeX's
text_Moves_zh-Hans.txt,text_Abilities_zh-Hans.txtandtext_Items_zh-Hans.txthave the same new names.Why the latest name
The name tables hold one name per language, and existing rows already follow renames:
vice-gripbut the English name "Vise Grip", its name from Sword/Shield on.Not changed
Trade-off
Clients that match on the old Simplified names will no longer find them. If you would rather keep first-release names, feel free to close this.
How to test
Data-only change. Build the database (
make build-db) and check thenamesof/api/v2/move/12/,/api/v2/ability/106/and/api/v2/item/224/.AI coding assistance disclosure
I used Claude Code to compare the zh-Hans name rows against the game text dumps across games and to apply the 27 edits. I checked each changed row against the source myself.
Contributor check list