Repository navigation
fix: add missing Chinese names and correct Roto-Stick spelling - #1715
Merged
Merged
Conversation
Naramsim
approved these changes
Nov 11, 2026
|
This Pull Request won't be deployed since the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Adds Chinese (zh-Hans and zh-Hant) names that were missing for Gen 9 data, and fixes one English item name.
Genus for species 1011-1025 (
pokemon_species_names.csv)These 15 species had Chinese names but an empty genus.
Ability names (
ability_names.csv, new rows)Item names (
item_names.csv, new rows)roto-stickfresh-start-mochiEnglish name of item 2100
Roto Stick→Roto-Stick, as the games spell it. The identifierroto-stickis unchanged.Source
Game text dumps at abcboy101/poke-corpus:
MONSNAME_ntoZKN_TYPE_n) in Scarlet/Violet, Legends: Z-A and HOME. All three give the same value, and the English genus on the same label matches the existing English row.ITEMNAME_2480(Roto-Stick) andITEMNAME_2479(Fresh-Start Mochi) in the same three dumps, matching the Gen 9 indices initem_game_indices.csv. PKHeX's item lists have the same English and Chinese names.tokuseisection of the Champions and HOME dumps, matched on the English name. These abilities were introduced in Champions, so no older source carries them.Scope
Chinese only. Several other languages still lack these genus values, and abilities 312-314 still have no names beyond English and Chinese.
How to test
Data-only change. Build the database (
make build-db) and check/api/v2/pokemon-species/1011/(genera),/api/v2/ability/312/(names) and/api/v2/item/2100/(names).AI coding assistance disclosure
I used Claude Code to locate the missing values in the game text dumps and to write them into the CSVs with a script that copies them from the dumps. I reviewed the resulting diff row by row.
Contributor check list